Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

노드 색상이 제대로 업데이트 되지 않는 버그 수정 #387

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Tolerblanc
Copy link
Member

🔖 연관된 이슈

📂 작업 내용

  • node.color를 구조분해할당으로 받아오고, 기본 값을 설정하지 않도록 수정

📢 리뷰 요구사항 (선택)

  • 브랜치 명 오타있는데 못 본 척 해주세요...

@Tolerblanc Tolerblanc added 🐧🚀😶‍🌫️ BE 백엔드 관련 이슈/PR 추적 라벨 🐛 Bug 무언가 정상적으로 동작하지 않는 경우 labels Dec 3, 2024
@Tolerblanc Tolerblanc requested a review from Copilot December 3, 2024 12:56
@Tolerblanc Tolerblanc linked an issue Dec 3, 2024 that may be closed by this pull request

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

apps/websocket/src/yjs/yjs.service.ts:266

  • The removal of the default color assignment may cause issues if node.data.color is undefined. Consider adding a default value to ensure color is always defined.
const { id, color } = node.data;
@github-actions github-actions bot merged commit fc6b107 into develop Dec 3, 2024
24 checks passed
@github-actions github-actions bot deleted the bug-be-#368 branch December 3, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐧🚀😶‍🌫️ BE 백엔드 관련 이슈/PR 추적 라벨 🐛 Bug 무언가 정상적으로 동작하지 않는 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

노드 색상을 흰색으로 덮어서 업데이트하는 버그
2 participants