-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cephes Updates #1704
Cephes Updates #1704
Conversation
Hi Varun, per the discussions in #1605 and (recent Windows-related issue), can we just make this header all inline? These symbols does not need to be exported if they are only used internally, and we save one extra dynamic library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the source files are licensed with the Boost license, for example, here:
/*
* (C) Copyright John Maddock 2006.
* Use, modification and distribution are subject to the
* Boost Software License, Version 1.0. (See accompanying file
* LICENSE_1_0.txt or copy at https://www.boost.org/LICENSE_1_0.txt)
*/
in igami.c
that we are using. Could you add this to the LICENSE.txt?
I think this is fine and doesn't need to be added to the LICENSE.txt file since the Boost license states that only the license header should be added to files using Boost code (which is already done). I'll go ahead and merge this PR. |
I faced a problem with this /usr/local/include/gtsam/3rdparty/cephes/cephes.h:4:10: fatal error: dllexport.h: No such file or directory
4 | #include "dllexport.h"
| ^~~~~~~~~~~~~
compilation terminated. This compilation error was fixed by adding EDIT:
|
@zzodo Could you put up a quick PR? |
extern
support.