-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly deal with sensor rotation in AHRS #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellaert
commented
Jun 9, 2024
dellaert
commented
Jun 9, 2024
@andre-michelin Please review and confirm these changes work in our code? |
Thanks @varunagrawal , I addressed two of your comments in my local repo but will wait for Andre's comments to push, so we have to do CI only once more before merging. |
andre-michelin
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sensor
displacementrotation was not handled correctly in the AHRS factors. I spent a day tracking it down and fixed it:testAHRSFactor.cpp
, now usesFactorTesting.h
macrosPreintegratedRotation
with hard-to-understand JacobiansbiascorrectedDeltaRij
) but fixes bugTested:
testPreintegratedRotation.cpp
, all tests passtestAHRSFactor.cpp
, inspired bytestImuFactor.cpp
testManifoldPreintegration.cpp
to establish equivalence