DiscreteConditional and DiscreteBayesNet improvements
#1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellaert
requested changes
Jul 13, 2024
There was a problem hiding this comment.
I think the mode function is not correct. The correct way to compute the mode is converting to a factor graph and calling max-product. There will be cases where they give the same result, but not in general. I think I even have a counter-example in the tests somewhere.
| // Check argmax on P(C|D) and P(D) | ||
| TEST(DiscreteConditional, Argmax) { | ||
| DiscreteKey C(2, 2), D(4, 2); | ||
| DiscreteConditional D_cond(D, "1/3"); |
| TEST(DiscreteConditional, Argmax) { | ||
| DiscreteKey C(2, 2), D(4, 2); | ||
| DiscreteConditional D_cond(D, "1/3"); | ||
| DiscreteConditional C_given_DE((C | D) = "1/4 1/1"); |
|
|
||
| // Case 1: No parents | ||
| size_t actual1 = D_cond.argmax(); | ||
| EXPECT_LONGS_EQUAL(1, actual1); |
There was a problem hiding this comment.
Why is it 1? Document how tie-breaking will be handled in argmax
dellaert
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DiscreteConditional.DiscreteConditional::argmaxfor arbitrary conditionals, not just conditionals with no parents.DiscreteLookupTableandDiscreteConditional.