-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More tests, some small bugfixes #1854
Conversation
dellaert
commented
Sep 30, 2024
•
edited
Loading
edited
- added comprehensive tests in HybridBayesNet
- fixed a number of issues in test frameworks, equality checking, etc.
- added choose method in HGC, operator() now sugar
- made sample more aware of bad inputs
- made potentiallyPrunedComponentError a local function
- refactored printErrors -> polymorphic error works fine!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some major comments about Switching.h
, and some nitpicks.
I'd rather not do another CI so please approve and I'll make the small changes in the next PR. I think it's basically only small change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still not sure about the K values though.
K is number of variables X, K-1 modes, right? |