Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests, some small bugfixes #1854

Merged
merged 11 commits into from
Sep 30, 2024
Merged

More tests, some small bugfixes #1854

merged 11 commits into from
Sep 30, 2024

Conversation

dellaert
Copy link
Member

@dellaert dellaert commented Sep 30, 2024

  • added comprehensive tests in HybridBayesNet
  • fixed a number of issues in test frameworks, equality checking, etc.
  • added choose method in HGC, operator() now sugar
  • made sample more aware of bad inputs
  • made potentiallyPrunedComponentError a local function
  • refactored printErrors -> polymorphic error works fine!

Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some major comments about Switching.h, and some nitpicks.

gtsam/hybrid/HybridGaussianConditional.cpp Show resolved Hide resolved
gtsam/hybrid/HybridGaussianFactor.cpp Show resolved Hide resolved
gtsam/hybrid/tests/Switching.h Show resolved Hide resolved
gtsam/hybrid/tests/Switching.h Show resolved Hide resolved
gtsam/hybrid/tests/Switching.h Show resolved Hide resolved
@dellaert
Copy link
Member Author

I'd rather not do another CI so please approve and I'll make the small changes in the next PR. I think it's basically only small change.

Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not sure about the K values though.

@dellaert
Copy link
Member Author

I am still not sure about the K values though.

K is number of variables X, K-1 modes, right?
for K=3: X(0), X(1), X(2), and M(0), M(1) i.e., modes end at K-2 = 3-2 = 1.

@dellaert dellaert merged commit caa3821 into develop Sep 30, 2024
33 checks passed
@dellaert dellaert deleted the feature/more_testing branch September 30, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants