Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precompiled_header.h: remove chartTesting.h #1870

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Oct 11, 2024

The chartTesting.h header is no longer used anywhere in the codebase, but it causes a compilation error on MSVC when building with C++20 or newer:

C:\Users\martin\.conan2\p\b\gtsam83ef710337281\b\src\gtsam\base\chartTesting.h(42,3): error C3878: syntax error: unexpected token ')' following 'expression_statement' [C:\Users\martin\.conan2\p\b\gtsam83ef710337281\b\build\gtsam 
\gtsam.vcxproj]
  (compiling source file '../../src/gtsam/precompiled_header.cpp')

This PR removes it from the list of precompiled headers as a fix. Should the chartTesting.h header be removed altogether, perhaps?

Fixes #1788.

Not used anywhere and fails to compile with C++20 on MSVC:

gtsam\base\chartTesting.h(42,3): error C3878: syntax error: unexpected token ')' following 'expression_statement'
Copy link
Collaborator

@ProfFan ProfFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ProfFan ProfFan merged commit e6dfa7b into borglab:develop Oct 12, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build with msvc and C++20
2 participants