-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EssentialTransferFactor #1887
EssentialTransferFactor #1887
Conversation
db872bc
to
c953ae7
Compare
@travisdriver was able to run Python version of EssentialViewGraphExample, see new commits :-) |
739f3b5
to
8dd6eb1
Compare
8dd6eb1
to
bbba497
Compare
* @brief Transfers points between views using essential matrices, optimizes for | ||
* calibrations of the views, as well. Note that the EssentialMatrixFactor4 does | ||
* something similar but without transfer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think optimization of the calibrations should be reserved for the transfer factors that leverage the fundamental matrix, and this factor should only optimize values involved with the essential matrix, i.e., the relative orientation and direction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the TransferFactor above, templated on EssentialMatrix
, to optimize for R,t only. This factor does E and Ks simultaneously. It works very well as the data bears out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll think of better name
...
In maximum-likelihood settings the more DOF, the less the error will be, but you will overfit on the noise. The graph shows that this is exactly what happens: the error is lowest for models with most parameters, but if we measure the geodesic distance to the ground truth, the models with the (correct) inductive biases are better, on average. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo adding something to the name that indicates calibrations are being optimized
New factor does transfer using E, but also introduces calibration unknowns for the views. So, potentially O(N^2) E unknowns, but only O(N) calibration unknowns. Currently keys are derived from edges but should be possible to overwrite them.
Example output: