Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F wrapper and bugfix #1888

Merged
merged 14 commits into from
Oct 31, 2024
Merged

F wrapper and bugfix #1888

merged 14 commits into from
Oct 31, 2024

Conversation

dellaert
Copy link
Member

@dellaert dellaert commented Oct 28, 2024

  • changed internal representation of F to fix a bug when flipping U or V
  • now flip columns of U and V which always allows for $U*diag(1,s,0)*V^T$
  • added wrapper definitions
  • added python unit test

@dellaert
Copy link
Member Author

@akshay-krishnan , @travisdriver please look at FundamentalMatrix.h first, then rest will make sense. This PR should also make the last PR easier to review.

gtsam/geometry/FundamentalMatrix.h Outdated Show resolved Hide resolved
gtsam/geometry/FundamentalMatrix.h Outdated Show resolved Hide resolved
gtsam/geometry/FundamentalMatrix.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@akshay-krishnan akshay-krishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not look at the tests, rest LGTM!

@dellaert dellaert merged commit 67495ba into develop Oct 31, 2024
33 checks passed
@dellaert dellaert deleted the feature/wrapF branch October 31, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants