Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better HybridSmoother #1996

Merged
merged 18 commits into from
Jan 25, 2025
Merged

Better HybridSmoother #1996

merged 18 commits into from
Jan 25, 2025

Conversation

varunagrawal
Copy link
Collaborator

Updated the HybridSmoother to

  1. Only use conditionals connected to the variables which are connected to the new factors being added.
  2. Improve the getOrdering method to give orderings that don't include all the variables.
  3. Removed extra loops and made the whole things a bit more efficient.

@varunagrawal varunagrawal requested a review from dellaert January 24, 2025 02:15
@varunagrawal varunagrawal self-assigned this Jan 24, 2025
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some weirdness in .h file, doxygen of get ordering …

@varunagrawal
Copy link
Collaborator Author

Fixed the doxygen issue. That was my mistake, trying to regenerate the docstring automatically.

CI will pass once we merge in #1999.

@dellaert
Copy link
Member

Merge at will

@varunagrawal varunagrawal merged commit 3302ad4 into develop Jan 25, 2025
35 checks passed
@varunagrawal varunagrawal deleted the hybrid-smoother branch January 25, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants