Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use align_robust from Colmap to align reconstructions #776

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Use align_robust from Colmap to align reconstructions #776

merged 1 commit into from
Jan 29, 2024

Conversation

ayushbaid
Copy link
Contributor

align_robust offers a robust alignment mechanism to align a reconstruction to list of camera positions (no orientation), which looks to work better than GTSFM's logic

travisdriver
travisdriver approved these changes Jan 28, 2024
View reviewed changes
Copy link
Collaborator

@travisdriver travisdriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@travisdriver
Copy link
Collaborator

travisdriver commented Jan 28, 2024 •
edited
Loading

align_robust offers a robust alignment mechanism to align a reconstruction to list of camera positions (no orientation), which looks to work better than GTSFM's logic

Does this mean it doesn't use orientation as all to compute the Sim(3)?

@ayushbaid
Copy link
Contributor Author

align_robust offers a robust alignment mechanism to align a reconstruction to list of camera positions (no orientation), which looks to work better than GTSFM's logic

Does this mean it doesn't use orientation as all to compute the Sim(3)?

Yep looks like that.

@ayushbaid
Copy link
Contributor Author

align_robust offers a robust alignment mechanism to align a reconstruction to list of camera positions (no orientation), which looks to work better than GTSFM's logic

Does this mean it doesn't use orientation as all to compute the Sim(3)?

Yep looks like that.

Atleast not absolute wTis. Maybe it uses relative rotations

@ayushbaid ayushbaid merged commit 3791a27 into master Jan 29, 2024
24 checks passed
@ayushbaid ayushbaid deleted the feature/compare_colmap_poses branch January 29, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisdriver travisdriver travisdriver approved these changes

@akshay-krishnan akshay-krishnan Awaiting requested review from akshay-krishnan

@johnwlambert johnwlambert Awaiting requested review from johnwlambert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayushbaid @travisdriver