improve flash-attn error message #209
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating error message from "flash-attn is not installed" to "a compatible version of flash-attn is not installed," since the former error message is confusing to those who actually do have flash-attn installed, just a more recent version (not <1.0.5) in which flash_attn.flash_attention.FlashMHA is no longer included
|
actually, I am getting this warning message even in my environment that has flash-attn 1.0.4, so now I'm not sure why I'm getting the warning, and my updated error message isn't sufficient to explain it. I will write back if I figure it out |
|
The reason I was getting the error even with flash-attn 1.0.4 installed was because my pytorch version was incompatible with my flash-attn version, so the import statement was failing. I still think updating the warning message may lead to less confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating error message from "flash-attn is not installed" to "a compatible version of flash-attn is not installed," since the former error message is confusing to those who actually do have flash-attn installed, just a more recent version (not <1.0.5) in which flash_attn.flash_attention.FlashMHA is no longer included