Remove unnecessary play services dependency #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxdesmarais
approved these changes
May 14, 2024
| @@ -63,7 +63,6 @@ dependencies { | |||
| implementation 'androidx.appcompat:appcompat:1.4.0-alpha03' | |||
| implementation 'androidx.cardview:cardview:1.0.0' | |||
|
|
|||
| implementation 'com.google.android.gms:play-services-wallet:16.0.1' | |||
There was a problem hiding this comment.
Is this worthy of a CHANGELOG entry or not something that merchants would notice?
There was a problem hiding this comment.
They shouldn't notice it - we were duplicate including this dependency (already bundled with the core Google Play module) so it was already resolving to the higher version from core
sshropshire
reviewed
May 15, 2024
| @@ -284,6 +284,7 @@ private GooglePayRequest getGooglePayRequest() { | |||
| .setTotalPriceStatus(WalletConstants.TOTAL_PRICE_STATUS_FINAL) | |||
| .build()); | |||
| googlePayRequest.setEmailRequired(true); | |||
| googlePayRequest.setCountryCode("BR"); | |||
There was a problem hiding this comment.
qq: Noticed this is set to Brazil?
There was a problem hiding this comment.
Yeah in prod there's currently an error with our default allowed card networks (I think Maestro or some other one requires the country code to be BR) - updated this rather than changing allowed card networks
There was a problem hiding this comment.
Oh ok yeah that makes total sense 👍
sshropshire
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
[ ] Added a changelog entryAuthors