Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary play services dependency #476

Merged
merged 1 commit into from
May 15, 2024
Merged

Remove unnecessary play services dependency #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Demo/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ dependencies {
implementation 'androidx.appcompat:appcompat:1.4.0-alpha03'
implementation 'androidx.cardview:cardview:1.0.0'

implementation 'com.google.android.gms:play-services-wallet:16.0.1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this worthy of a CHANGELOG entry or not something that merchants would notice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They shouldn't notice it - we were duplicate including this dependency (already bundled with the core Google Play module) so it was already resolving to the higher version from core

implementation 'com.squareup.retrofit:retrofit:1.9.0'
implementation 'io.card:android-sdk:5.5.1'

Expand Down
1 change: 1 addition & 0 deletions Demo/src/main/java/com/braintreepayments/demo/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ private GooglePayRequest getGooglePayRequest() {
.setTotalPriceStatus(WalletConstants.TOTAL_PRICE_STATUS_FINAL)
.build());
googlePayRequest.setEmailRequired(true);
googlePayRequest.setCountryCode("BR");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq: Noticed this is set to Brazil?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah in prod there's currently an error with our default allowed card networks (I think Maestro or some other one requires the country code to be BR) - updated this rather than changing allowed card networks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok yeah that makes total sense 👍

return googlePayRequest;
}

Expand Down
1 change: 0 additions & 1 deletion Drop-In/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ dependencies {
api 'com.braintreepayments:card-form:5.4.0'

implementation 'androidx.cardview:cardview:1.0.0'
implementation 'com.google.android.gms:play-services-wallet:16.0.0'
implementation 'androidx.recyclerview:recyclerview:1.2.1'
implementation 'com.google.android.material:material:1.4.0'
implementation 'androidx.constraintlayout:constraintlayout:2.0.4'
Expand Down
Loading