Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#298 Update Node to v18 + switch to npm #288

Merged
merged 7 commits into from
Mar 7, 2025
Merged

#298 Update Node to v18 + switch to npm #288

merged 7 commits into from
Mar 7, 2025

Conversation

radoslavzeman
Copy link
Contributor

No description provided.

@radoslavzeman radoslavzeman linked an issue Feb 28, 2025 that may be closed by this pull request
Update node to v18 #287
Closed
@radoslavzeman radoslavzeman requested a review from Ty-ci February 28, 2025 14:13
@radoslavzeman radoslavzeman mentioned this pull request Mar 6, 2025
Merged
@radoslavzeman radoslavzeman requested a review from vidriduch March 6, 2025 08:38
vidriduch and others added 3 commits March 7, 2025 13:39
@vidriduch
Update Strapi & Next Dockerfiles
8a9d282 
* Remove yarn and replaced it with npm
* Fix Strapi node version image, due to issue nodejs/docker-node#2009
* Restructure Dockerfile to make sense with new npm configuration
@radoslavzeman
Create package-lock.json and pin npm version
764248c
@vidriduch
Renamed Dockerfile stages
c9ec972 
* Renamed Dockerfile stages to better represent their function
* Added update to app-base install
* Added comment to Strapi Dockerfile with relevant issue causing freeze on node image version
@radoslavzeman radoslavzeman changed the title #298 Update Node to v18 #298 Update Node to v18 nad switch to npm Mar 7, 2025
@radoslavzeman radoslavzeman changed the title #298 Update Node to v18 nad switch to npm #298 Update Node to v18 + switch to npm Mar 7, 2025
@github-actions github-actions bot added pr: fix & ship 🚢 No additional review needed before merge - some work may be required, if specified in last review and removed pr: needs review 🙏 labels Mar 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025 •
edited
Loading

Test build pipeline info 🚀

Changes in the code and tag info:

➡️ Changes in strapi: true

➡️ Changes in next: true

We are going to build 🚢

🔜 strapi

🔜 next

🥳 Bratiska-cli successfully built an image from path: strapi/
🥳 Bratiska-cli successfully built an image from path: next/

@radoslavzeman radoslavzeman merged commit 5b87a0f into master Mar 7, 2025
15 checks passed
@radoslavzeman radoslavzeman deleted the 287-update-node-to-v18 branch March 7, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vidriduch vidriduch vidriduch approved these changes

@Ty-ci Ty-ci Awaiting requested review from Ty-ci

Assignees
No one assigned
Labels
pr: fix & ship 🚢 No additional review needed before merge - some work may be required, if specified in last review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update node to v18
2 participants
@radoslavzeman @vidriduch