Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update onboarding to new design and flow #26378

Closed
nullhook opened this issue Oct 29, 2022 · 7 comments · Fixed by brave/brave-core#15637
Closed

Update onboarding to new design and flow #26378

nullhook opened this issue Oct 29, 2022 · 7 comments · Fixed by brave/brave-core#15637

Comments

@nullhook
Copy link

nullhook commented Oct 29, 2022

Description

Update the onboarding UI/UE to the new design and flow.

  • First run dialog for Windows/macOS/Linux will be hidden/disabled Disable first run dialog temporarily #27225
  • brave://welcome will be shown as the first screen on first launch (after successful installation)
  • brave://welcome will give users the ability to Set Brave as Default or skip to next screen
  • Second screen will give users the ability import from the browsers installed on their machine: Chrome, Chrome Beta, Chrome Canary, Edge, Internet Explorer, Firefox, Opera, and Vivaldi. The default browser will be default selected.
  • If there is more than one user profile in Chromium based browsers, we will show an additional selection screen to allow which profiles to import. Multiple selection and import of all profiles are supported.
  • If there are no browsers to import with the main use case being Safari import, then users will fallback to selecting theme color Add flow for no browser detected when onboarding #27170
  • There will be a confirmation screen after import.
  • The final screen will show Help Improve Brave screen. Diagnostic reports for crashes and freezes should be default checked #27126
  • After completing the onboarding, users will be taken to the New tab page.

Actual result:

Screenshot 2022-12-09 at 7 44 50 AM

Expected result:

Screenshot 2022-12-09 at 7 45 22 AM

https://www.figma.com/file/MFHpcXJMg2RUQpUJMAZZ4R/Desktop-Onboarding?node-id=3325%3A42022&t=FNxONWq75FP9PByP-0

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Related issues:
brave/brave-core#16208
#27126
#27253

brave/brave-core#16164
#26851
#27060
#27061
#27105

@LaurenWags
Copy link
Member

QA/Blocked - per @rebron test plan still needed

@rebron rebron changed the title Implement the new onboarding UI Update onboarding to new design and flow Dec 9, 2022
@rebron
Copy link
Collaborator

rebron commented Dec 9, 2022

Testing requires 1.48.41 and higher.

@rebron
Copy link
Collaborator

rebron commented Dec 9, 2022

@nullhook @LaurenWags Note for multiple profile import to ensure that the profiles are imported separately and the default profile for the one imported remains the default profile in Brave.

Check for other case for multiple profile import, if default profile for the imported browser is not selected but other profiles are, which profile becomes default in Brave. Unclear on what the ordering/selection should be.

@LaurenWags
Copy link
Member

as discussed during today's QA walkthrough, this will be tested in 1.47.x, but requires uplifts before beginning (see "Related issues" in #26378 (comment)) so this issue remains blocked until the 2 "Related issues" PRs are uplifted.

There will be another uplift, but it's macOS specific and wouldn't hold up testing of this issue on Win/Linux.

@MadhaviSeelam
Copy link

MadhaviSeelam commented Dec 15, 2022

Verification PASSED using

Brave | 1.47.136 Chromium: 108.0.5359.128 (Official Build) beta (64-bit)
-- | --
Revision | 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS | Windows 11 Version 21H2 (Build 22000.1335)

and

Brave | 1.47.148 Chromium: 109.0.5414.46 (Official Build) beta (64-bit)
-- | --
Revision | 6e36b77363ef3febbe792af680fa1367993ddcf0-refs/branch-heads/5414@{#709}
OS | Windows 11 Version 21H2 (Build 22000.1335)

Test Case 1: New onboarding UI - brave://welcome page upon Brave launch - PASSED

  1. Install 1.47.136
  2. launch Brave
  3. verified First run dialog no longer displayed
  4. click Set Brave as default browser

Confirmed new onboarding UI is shown - brave://welcome page with Set Brave as a default browser and Skip buttons as the first screen

image

Test Case 2: Single browser and Single profile

Case 1: Second screen Import Settings will give users the ability to import and most recent used browser is set as a default - Edge - Failed

  • Pre-requisite: Microsoft Edge with a single profile with bookmarks, extensions, saved passwords
image
  1. continue from Test Case 1
    • brave://welcome page - Set Brave as default browser
  2. verified the second page listed pre-installed non-brave browsers - Microsoft Edge

####Confirmed Import Settings, displayed after setting Brave as default
*Chromium based browser was checked by default on Import Settings page - Failed
*Most recent used browser was Edge, and it was not checked by default - Failed

image

Filed: *#27522

Case 2 Set Brave as default and complete import from Microsoft Edge - PASSED

  1. continue from Case 1
    • brave://welcome page - import settings screen
  2. select Microsoft Edge
  3. click Import button
  4. open brave://settings/appearance
  • Confirmed Setup complete screen is displayed
  • Confirmed Help improve Brave screen is displayed
  • Confirmed Brave is your default browser message is shown
step 2-3 result result result
image image image image

Case 3: Verify default settings in the Help improve brave better screen - PASSED

  1. continue Case 2
    • Help improve Brave better screen is displayed
  2. verified Send diagnostic reports if you experience a crash or freeze entry is checked as default
  3. verified Share completely private and anonymous product insights about what features are being used by Brave's users entry is checked as default
  4. clicked brave://settings/privacy link beneath the Finish button
  5. brave://settings/privacy tab opened in a separate tab
  6. confirmed Automatically send diagnostic reports setting is enabled
  7. confirmed Allow privacy-preserving product analytics (P3A) setting is enabled
  8. click Privacy Policy link
  9. confirmed Brave Browser Privacy Policy page opened in a new-tab ---> brave://settings/privacy
  10. return to Help improve Brave better screen and click Learn more` links

Confirmed links on the page worked as expected

step 2-4 step 5-7 step 8-9 step 10a step 10b
image image image image image

Case 4: Verify Bookmarks, Extensions & Saved passwords are successfully imported from Edge - FAILED

  1. continue from Case 3:
    • Help improve Brave screen is displayed
  2. click Finish button
  3. confirmed new tab page is loaded as a first screen
  4. confirmed imported Bookmarks shown on the bookmarks bar and brave://bookmarks
  5. confirmed saved passwords shown in brave://settings/passwords
  6. confirmed history shown in brave://history

####Confirmed Bookmarks imported successfully
####Confirmed Saved passwords imported successfully
****Extensions are not imported - *#27487

bookmarks saved passwords history
image image image

Case 5: Uncheck default settings in the Help improve brave better screen - PASSED

  1. new profile
  2. launch Brave
  3. click Set Brave as default browser
  4. select Microsoft Edge
  5. click Import button
  6. confirmed Setup complete page shown
  7. uncheck Send diagnostic reports if you experience a crash or freeze entry
  8. uncheck Share completely private and anonymous product insights about what features are being used by Brave's users entry
  9. click Finish
  10. confirmed new tab page with imported bookmarks shown on the bookmarks bar
  11. open brave://settings/privacy in a new tab page

####Confirmed Automatically send diagnostic reports setting is disabled
####Confirmed Allow privacy-preserving product analytics (P3A) setting is disabled

step 3 step 4-5 step 6 step 7-9 step 10 result
image image image image image image

Case 6: Do not set Brave as default & do not import - PASSED

Prerequisite: Microsoft Edge as a default browser in `Windows` settings
  1. new profile
  2. launch Brave
  3. click Skip on brave://welcome screen
  4. click Skip on Import Settings screen
  5. click finish
  6. new-tab page is shown
  7. go to brave://settings/getStarted

####Confirmed no profile data is imported.
####Confirmed Brave://settings/getStarted page shown Make default button

Prerequisite step 3 step 4 step 5 step 6 step 7
image image image image image image

Filed: *#27554

Case 7: Set Brave as default but do not import - PASSED

  1. new profile
  2. launch Brave
  3. click Set Brave as default browser on brave://welcome screen
  4. click Skip on Import Settings screen
  5. click finish
  6. new tab page is shown without any Profile data
  7. go to brave://settings/getStarted

Confirmed Brave is your default browser message shown

step 3 step 4 step 5 step 6 result
image image image image image

Case 8: Do not set Brave as default but import Profile data - PASSED

Prerequisite: Microsoft Edge as a default browser in `Windows` settings
  1. new profile
  2. launch Brave
  3. click Skip on brave://welcome screen
  4. click Import on Import Settings screen
  5. check Microsoft Edge
  6. check the checkbox for Microsoft Edge Profile 2
  7. click import profiles button
  8. click Finish
  9. go to brave://settings/getStarted

Confirmed new tab page shown with Profile data is imported (Bookmarks, Save passwords)

*Brave://settings/getStarted page should show Make default button instead page shows Brave is your default browser message.

pre-req step 3 step 4 step 5 step 7 step 8 result result
image image image image image image image image

Case 9: Set Brave as default and skip import from onboarding UI, but proceed to import from brave://settings/importData - Failed

Prerequisite: Make sure Microsoft Edge as a default browser in `Windows

  1. new profile
  2. launch Brave
  3. click Set Brave as default browser
  4. click Skip
  5. click Finish
  6. verified new tab page opened as expected
  7. brave://settings/getStarted
  8. Brave is your default browser message shown
  9. open brave://settings/importData
  10. select Microsoft Edge Profile 1
  11. click Import

####Confirmed bookmarks are imported and shown in the Bookmarks side panel
*Extensions are not imported - *#27487
*Click Import button on Import bookmarks and settings modal failed to dismiss- *#27425

prerequisite step 3 step 4 step 5 step 6 step 8 step 9-10 step 11
image image image image image image image image

Test Case 3: Single browser & Multiple profiles

Case 1: Set Brave as default and import from multiple profiles - Microsoft Edge - PASSED

Pre-requisite: Created 4 Profiles in Microsoft Edge with following:

  • Profile 1: Bookmarks, Saved Passwords, Extensions, History
  • Profile 2: Bookmarks
  • Profile 3: Bookmarks
  • Profile 4: No favorites

image

  1. new profile
  2. launch Brave
  3. click Set Brave as default browser
  4. select Microsoft Edge
  5. clicked Import
  6. confirmed all 4 profiles (Profile 1 - 4) displayed on Select profile to import modal
  7. clicked Select All to select
  8. unchecked Profile 3
  9. clicked Back
  10. navigated to Import Settings screen
  11. clicked Import again
  12. selected Profiles 1, 2, & 4
  13. clicked Import profiles
  14. confirmed Setup Complete confirmation screen shown
  15. click Finish
  16. new tab page shown with bookmarks on the bookmarks bar

####Confirmed Bookmarks from Profile 1 and 2 are successfully imported
####Confirmed Saved passwords from Profile 1 are successfully imported

step3 step 5 step 7 step 8 step 9-10 step 12 step 15 step 16 passwords
image image image image image image image image image

Test Case 4: Multiple browsers and Multiple profiles

Case 1: Verify all installed non-Brave browsers are shown in the Import Settings page - FAILED

Pre-requisites:
Have import supported browsers installed
Chrome, Chrome Beta, Chrome Dev, Chrome Canary, Edge, Firefox, Opera, and Vivaldi

  1. new profile
  2. launch Brave
  3. click Set Brave as default browser button on brave://welcome page

Confirmed Chrome, Chrome Canary, Edge, Firefox, Opera, and Vivaldi browsers listed

*Chrome Beta and Chrome Dev are not listed

ex1 ex2
image image

Filed
*#27500

Case 2: Do not show all Chrome channels in the Select profile to import screen when Chrome (Stable) selected in Import Settings page - FAILED

  1. new profile
  2. launch Brave
  3. click Set Brave as default browser button on brave://welcome page
  4. select Chrome
  5. click Import

*Profiles from Chrome Beta and Dev channels also rendered. Should list only Chrome stable channel
- Chrome Beta Person 1
- Chrome Dev Person 1
- Chrome Dev Person 2

Case 3: Set Brave as default and import from multiple browsers with multiple profiles - Select individually -PASSED

Firefox

Create 4 Firefox profiles:
Profile 1: Bookmarks, Extensions, Saved passwords
Profile 2: Bookmarks, Extensions
Profile 3: Bookmarks
Profile 4: No data
image

  1. new profile
  2. launch Brave
  3. click Set Brave as default browser button on brave://welcome page
  4. select Mozilla Firefox on Import Settings screen
  5. click Import
  6. click Select All
  7. click Import profiles
  8. click Finish
step 3 step 4-5 step 5 step 6-7 step 8 result
image image image image image image

Chrome Stable - PASSED

Profile 1: Bookmarks, Saved passwords, Extensions
Profile 2: Bookmarks
Profile 3: No Data
Profile 4: Bookmarks
Profile 5: Bookmarks

image
  1. new profile
  2. launch Brave
  3. click Set Brave as default browser
  4. select Chrome
  5. click Import
  6. click Select All and unselect Chrome Person 2
  7. click Import profiles
  8. click Finish

####Confirmed Bookmarks, saved passwords are successfully imported from Profile 1
####Confirmed Bookmarks from Profiles 4 & 5 are imported
####Confirmed Profile 2 data is unchecked, so no data is imported

step 3 step 4-5 step 6-7 step 8 result ex
image image image image image

Case 4: Set Brave as default and import from multiple browsers with multiple profiles simultaneously - FAILED

Chrome Canary
Profile 1: Bookmarks & Saved passwords
Profile 2: Bookmarks
image

  1. new profile
  2. launch Brave
  3. click Set Brave as default browser
  4. select multiple browsers simultaneously - Chrome Canary, Chrome Beta, Chrome Dev & Opera

*Could not select multiple browsers simultaneously

step 3 step 4-5
image image

Chrome Beta - Failed - not listed

Profile 1: Extensions & Saved passwords
image

  • Chrome Beta channel is not listed
    image

Chrome Dev - Failed

Profile 1: Bookmarks, Saved passwords, Extensions
Profile 2: Bookmarks

image

Vivaldi

Create 3 Vivaldi profiles
Profile 1: Bookmarks, Extensions, Saved passwords
Profile 2: Bookmarks
Profile 3: No data

image

Filed:
*#27500

Test Case 5: Upgrade

Case 1: Previously onboarding is completed - PASSED

  1. Install 1.46.144
  2. launch Brave
  3. click Skip welcome tour link
  4. new tab page shown as expected
  5. close Brave
  6. rename the profile to Beta
  7. launch Brave

Confirmed new onboarding UI is not displayed.

step 1 step 2-3 step 4 step 7 result
image image image image image

Case 2: If previously onboarding is not completed, new onboarding UI is shown -PASSED

  1. Install 1.46.144
  2. launch Brave
  3. do not click Skip welcome tour link and close Brave
  4. rename the profile to Beta
  5. launch Brave

Confirmed new onboarding UI is displayed.

step 1 step 3 result result
image image image image

Test Case 6: Background animations only work if hardware acceleration is enabled and "Reduce motion" flag disabled

Case 1: Disable HW accel --disable-gpu - PASSED

  1. new profile
  2. launch Brave with Disable HW accel flag --disable-gpu

Confirmed no animation played upon Brave launch on brave://welcome - first screen

2022-12-29_10h05_52.mp4

Case 2: Enable HW accel and Reduced motion should be checked - PASSED

  1. new profile
  2. open Windows settings >Accessibility > Visual effects >
  3. toggle Off Animation effects
  4. launch Brave

step 3

image

launch Brave (without flags)

2022-12-29_10h15_40.mp4

launch Brave (explicitly set --enable-gpu)

2022-12-29_10h21_24.mp4

Bugs filed:

Encountered:

Closed: Invalid

Related:

@LaurenWags
Copy link
Member

Removing QA/Blocked as required uplifts (brave/brave-core#16321) to 1.47.x were done

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 28, 2022
@stephendonner
Copy link

stephendonner commented Dec 28, 2022

Verification PASSED using

Brave 1.47.155 Chromium: 109.0.5414.46 (Official Build) beta (x86_64)
Revision 6e36b77363ef3febbe792af680fa1367993ddcf0-refs/branch-heads/5414@{#709}

(Where noted)

And, chiefly:

Brave 1.47.151 Chromium: 109.0.5414.46 (Official Build) beta (x86_64)
Revision 6e36b77363ef3febbe792af680fa1367993ddcf0-refs/branch-heads/5414@{#709}
OS macOS Version 11.7.2 (Build 20G1020)

Section 1: New onboarding UI - brave://welcome page upon Brave launch - PASSED

  1. installed 1.47.151
  2. launched Brave
  3. verified no more first-run dialog
  4. examined new screen

Confirmed new onboarding UI is shown from brave://welcome page with Set Brave as default browser button and Skip text link as the first screen

Dark Light
Screen Shot 2022-12-28 at 12 49 15 PM Screen Shot 2022-12-28 at 12 49 03 PM

Section 2: Single browser and single profile

Case 1: Second screen Import Settings will give users the ability to import, with most-recently-used browser set as a default import option - FAILED

Pre-requisite: Microsoft Edge installed, with a single profile with bookmarks, extensions, and saved passwords

  1. continued from Section 1
  2. clicked Set Brave as default browser
  3. examined the list of available browsers from which to import

Confirmed Microsoft Edge was available as an import option

  • Most-recently used browser was Edge, and it was not checked by default - FAILED
Screen Shot 2022-12-28 at 1 11 27 PM

Case 2: Set Brave as default and complete import from Microsoft Edge - PASSED

  1. continued from Section 1
  2. selected Microsoft Edge
  3. clicked Import button
  4. opened brave://settings/appearance

Confirmed:

  • Setup complete screen was displayed
  • Help improve Brave screen was displayed
  • Brave is your default browser message is shown
steps 2-3 result result result
Screen Shot 2022-12-28 at 1 27 08 PM Screen Shot 2022-12-28 at 1 27 13 PM Screen Shot 2022-12-28 at 1 27 21 PM Screen Shot 2022-12-28 at 1 27 36 PM

Case 3: Verify default settings in the Help make Brave better screen - PASSED

  1. continue from Case 2
    • Help improve Brave better screen is displayed
  2. verified Send diagnostic reports if you experience a crash or freeze entry is checked as default
  3. verified Share completely private and anonymous product insights about what features are being used by Brave's users entry is checked as default
  4. clicked brave://settings/privacy link beneath the Finish button
    5.brave://settings/privacy tab opened in a separate tab
  5. confirmed Automatically send diagnostic reports setting is enabled
  6. confirmed Allow privacy-preserving product analytics (P3A) setting is enabled
  7. clicked Privacy Policy link
  8. confirmed Brave Browser Privacy Policy page opened in a new-tab ---> brave://settings/privacy
  9. return to Help improve Brave better screen and click Learn more` links

Confirmed links on the page worked as expected

steps 2-4 steps 5-7 steps 8-9 step 10a step 10b
Screen Shot 2022-12-28 at 1 39 21 PM Screen Shot 2022-12-28 at 1 41 06 PM Screen Shot 2022-12-28 at 1 41 24 PM Screen Shot 2022-12-28 at 1 41 51 PM Screen Shot 2022-12-28 at 1 42 04 PM

Case 4: Verify bookmarks, extensions, and saved passwords are successfully imported from Edge - FAILED

  1. continue from Section 3:
    • Help improve Brave screen is displayed
  2. click Finish button
  3. confirmed new tab page is loaded as a first screen
  4. confirmed imported Bookmarks shown on the bookmarks bar and brave://bookmarks
  5. confirmed saved passwords shown in brave://settings/passwords
  6. confirmed history shown in brave://history

Confirmed bookmarks imported successfully

Confirmed saved passwords imported successfully

Confirmed history imported successfully

bookmarks saved passwords history
Screen Shot 2022-12-28 at 1 58 21 PM Screen Shot 2022-12-28 at 1 52 12 PM Screen Shot 2022-12-28 at 1 52 28 PM

Case 5: Uncheck default settings in the Help make Brave better page - FAILED

  1. new profile
  2. launch Brave
  3. click Set Brave as default browser
  4. select Microsoft Edge
  5. click Import button
  6. confirmed Setup complete page shown
  7. uncheck Send diagnostic reports if you experience a crash or freeze entry
  8. uncheck Share completely private and anonymous product insights about what features are being used by Brave's users entry
  9. click Finish
  10. confirmed new tab page with imported bookmarks shown on the bookmarks bar
  11. open brave://settings/privacy in a new tab page

Confirmed Automatically send diagnostic reports setting was disabled

  • Automatically send daily usage ping to Brave was enabled
step 3 step 4-5 step 6 step 7-9 step 10 result
Screen Shot 2022-12-28 at 2 10 00 PM Screen Shot 2022-12-28 at 2 10 11 PM Screen Shot 2022-12-28 at 2 10 17 PM Screen Shot 2022-12-28 at 2 10 25 PM Screen Shot 2022-12-28 at 2 10 30 PM Screen Shot 2022-12-28 at 2 11 26 PM

Encountered:

Case 6: Do not set Brave as default & do not import - PASSED

  1. new profile
  2. launch Brave
  3. click Skip on brave://welcome screen
  4. click Skip on Import Settings screen
  5. click finish
  6. new-tab page is shown
  7. go to brave://settings/getStarted

Confirmed no profile data is imported

Confirmed brave://settings/getStarted shows the Make default button (Firefox was default)

step 3 step 4 step 5 step 6 step 7
Screen Shot 2022-12-28 at 2 33 23 PM Screen Shot 2022-12-28 at 2 33 36 PM Screen Shot 2022-12-28 at 2 33 42 PM Screen Shot 2022-12-28 at 2 33 47 PM Screen Shot 2022-12-28 at 2 34 05 PM

Case 7: Set Brave as default but do not import - PASSED

  1. new profile
  2. launch Brave
  3. click Set Brave as default browser on brave://welcome screen
  4. click Skip on Import Settings screen
  5. click Finish
  6. new tab page is shown without any profile data
  7. go to brave://settings/getStarted

Confirmed Brave is your default browser message shown

step 3 default browser step 4 step 5 step 6 result
Screen Shot 2022-12-28 at 2 41 47 PM Screen Shot 2022-12-28 at 2 42 03 PM Screen Shot 2022-12-28 at 2 42 11 PM Screen Shot 2022-12-28 at 2 42 15 PM Screen Shot 2022-12-28 at 2 42 27 PM Screen Shot 2022-12-28 at 2 42 36 PM

Section 3 - Single browser with multiple profiles - PASSED

Case 1: Set Brave as default and import from multiple profiles - Microsoft Edge - PASSED

Prerequisite: Created 4 Profiles in Microsoft Edge with the following:

  • Profile 1: Bookmarks, Saved Passwords, Extensions, History
  • Profile 2: Bookmarks
  • Profile 3: Bookmarks
  • Profile 4: No favorites
  1. new profile
  2. launch Brave
  3. click Set Brave as default browser
  4. select Microsoft Edge
  5. clicked Import
  6. confirmed all 4 profiles (Profile 1 - 4) displayed on Select profile to import modal
  7. clicked Select All to select
  8. unchecked Profile 3
  9. clicked Back
  10. navigated to Import Settings screen
  11. clicked Import again
  12. selected Profiles 1, 2, & 4
  13. clicked Import profiles
  14. confirmed Setup Complete confirmation screen shown
  15. click Finish
  16. new tab page shown with bookmarks on the bookmarks bar

Confirmed Saved passwords from Profile 1 are successfully imported

Confirmed Bookmarks from Profile 1 and 2 are successfully imported

step 3 step 5 step 7 step 8 step 12 step 15 step 16 passwords bookmarks
Screen Shot 2022-12-28 at 4 16 11 PM Screen Shot 2022-12-28 at 4 16 30 PM Screen Shot 2022-12-28 at 4 16 39 PM Screen Shot 2022-12-28 at 4 17 33 PM Screen Shot 2022-12-28 at 4 17 38 PM Screen Shot 2022-12-28 at 4 25 56 PM Screen Shot 2022-12-28 at 4 17 42 PM Screen Shot 2022-12-28 at 4 18 43 PM Screen Shot 2022-12-28 at 4 18 04 PM

Case 2: Do not set Brave as default but import profile data - PASSED

  1. new profile
  2. launch Brave
  3. click Skip on brave://welcome screen
  4. click Import on Import Settings screen
  5. check Microsoft Edge
  6. check the checkbox for Microsoft Edge Profile 2
  7. click the Import profiles button
  8. click Finish
  9. go to brave://settings/getStarted

Confirmed new tab page shown with imported profile data (bookmarks)

pre-requisite step 3 step 5 step 7 step 8 result result
Screen Shot 2022-12-28 at 4 52 53 PM Screen Shot 2022-12-28 at 4 45 30 PM Screen Shot 2022-12-28 at 4 46 53 PM Screen Shot 2022-12-28 at 4 47 03 PM Screen Shot 2022-12-28 at 4 47 23 PM Screen Shot 2022-12-28 at 4 47 32 PM Screen Shot 2022-12-28 at 4 50 20 PM

Case 3: Set Brave as default and Skip import from onboarding UI, but proceed to import from brave://settings/importData - PASSED

  1. new profile
  2. launch Brave
  3. click Set Brave as default browser
  4. click Skip
  5. click Finish
  6. verified new tab page opened as expected
  7. open brave://settings/getStarted
  8. confirm Brave is your default browser
  9. open brave://settings/importData
  10. select Microsoft Edge Profile 1
  11. click Import

Confirmed bookmarks are imported and shown in the Bookmarks side panel

step 3 step 4 step 5 step 6 step 8 steps 9-10 result
Screen Shot 2022-12-28 at 5 12 32 PM Screen Shot 2022-12-28 at 5 12 46 PM Screen Shot 2022-12-28 at 5 13 05 PM Screen Shot 2022-12-28 at 5 13 11 PM Screen Shot 2022-12-28 at 5 13 29 PM Screen Shot 2022-12-28 at 5 13 50 PM Screen Shot 2022-12-28 at 5 15 18 PM

Section 4: Multiple browsers, each with multiple profiles - FAILED

Case 1: Verify all installed non-Brave browsers are shown in the Import Settings page - FAILED

Prerequisites:

  • Have import supported browsers installed:
    Chrome, Chrome Beta, Chrome Dev, Chrome Canary, Edge, Firefox, Opera, Safari, and Vivaldi
  1. new profile
  2. launch Brave
  3. click Set Brave as default browser button on brave://welcome page
  4. Confirmed Chrome, Chrome Canary, Edge, Firefox, Opera, and Vivaldi browsers were listed
  • Chrome Beta and Chrome Dev are not listed
Screen Shot 2022-12-28 at 2 48 25 PM

Encountered:

Case 2: Do not show all Chrome channels in the Select profile to import screen when Chrome (stable) is selected in the Import Settings screen - FAILED

  1. new profile
  2. launch Brave
  3. click the Set Brave as default browser button on brave://welcome page
  4. select Chrome
  5. click Import
  • Profiles from `Chrome (beta) and (dev) channels also displayed.
Chrome _non-stable_ branches
Screen Shot 2022-12-28 at 5 37 20 PM Screen Shot 2022-12-28 at 5 36 49 PM

Case 3: Set Brave as default and import from multiple browsers with multiple profiles - select individually - FAILED

Firefox - FAILED - logged #27561

Create 4 Firefox profiles:
Profile 1: Bookmarks, Extensions, Saved passwords
Profile 2: Bookmarks, Extensions
Profile 3: Bookmarks
Profile 4: No data

  1. new profile
  2. launch Brave
  3. click Set Brave as default browser button on brave://welcome page
  4. select Mozilla Firefox on Import Settings screen
  5. click Import
  6. click Select All
  7. click Import profiles
  8. click Finish

Confirmed bookmarks were imported from all 4 Firefox profiles

Failed to import extensions due to #27487 (will re-test)

Failed to find one of the profiles - logged #27561 (which now works)

Failed to import passwords from Profile 1

step 3 step 5 steps 6-7 step 8 Firefox profiles brave://settings/passwords brave://bookmarks brave://extensions
Screen Shot 2022-12-28 at 7 17 08 PM Screen Shot 2022-12-28 at 7 17 31 PM Screen Shot 2022-12-28 at 7 35 16 PM Screen Shot 2022-12-28 at 7 35 23 PM Screen Shot 2022-12-28 at 7 20 04 PM Screen Shot 2022-12-28 at 7 35 51 PM bookmarks extensions

Chrome Stable - PASSED

Profile 1: Bookmarks, Saved passwords, Extensions
Profile 2: Bookmarks
Profile 3: No Data
Profile 4: Bookmarks
Profile 5: Bookmarks

  1. new profile
  2. launch Brave
  3. click Set Brave as default browser
  4. select Chrome
  5. click Import
  6. click Select All and unselect Chrome Person 2
  7. click Import profiles
  8. click Finish

Confirmed Bookmarks, saved passwords are successfully imported from Profile 1

Confirmed Bookmarks from Profiles 4 & 5 are imported

Confirmed Profile 2 data is unchecked, so no data is imported

step 3 steps 4-5 steps 6-7 step 8 brave://bookmarks brave://settings/passwords
Screen Shot 2022-12-28 at 9 17 05 PM Screen Shot 2022-12-28 at 9 17 17 PM Screen Shot 2022-12-28 at 9 17 35 PM Screen Shot 2022-12-28 at 9 17 44 PM Screen Shot 2022-12-28 at 9 19 51 PM Screen Shot 2022-12-28 at 9 20 47 PM

Case 4: Set Brave as default and import from multiple browsers with multiple profiles (where supported) - simultaneously - FAILED

Build used:

Brave 1.47.155 Chromium: 109.0.5414.46 (Official Build) beta (x86_64)
Revision 6e36b77363ef3febbe792af680fa1367993ddcf0-refs/branch-heads/5414@{#709}
OS macOS Version 13.2 (a) (Build 22D7750270d)

Opera - FAILED(*)

Opera

example example example
Screenshot 2022-12-29 at 11 51 43 PM Screenshot 2022-12-29 at 11 54 32 PM Screenshot 2022-12-29 at 11 54 44 PM

Brave-imported profile

example example example example example
about:version onboarding screen selected Screenshot 2022-12-30 at 12 09 31 AM Screenshot 2022-12-30 at 12 09 17 AM

Confirmed bookmarks imported

Confirmed passwords imported

(*) Failed to confirm extensions, which were not imported

Firefox - FAILED

Firefox

example example example
Screenshot 2022-12-30 at 3 22 42 AM Screenshot 2022-12-30 at 3 23 01 AM Screenshot 2022-12-30 at 3 23 25 AM

Brave-imported profile

example example example example example example example
Screenshot 2022-12-30 at 3 43 25 AM Screenshot 2022-12-30 at 3 43 29 AM Screenshot 2022-12-30 at 3 43 31 AM Screenshot 2022-12-30 at 3 43 38 AM Screenshot 2022-12-30 at 3 43 47 AM Screenshot 2022-12-30 at 3 44 07 AM Screenshot 2022-12-30 at 3 43 20 AM

Confirmed bookmarks imported

Failed to import passwords

Failed to import extensions

Logged:

Chrome Beta - PASSED

Chrome Beta

example example
Screenshot 2022-12-30 at 1 36 37 PM Screenshot 2022-12-30 at 1 36 29 PM

Brave-imported profile

example example example example example example example example example example example
Screenshot 2022-12-30 at 2 04 32 PM Screenshot 2022-12-30 at 2 04 36 PM Screenshot 2022-12-30 at 2 04 42 PM Screenshot 2022-12-30 at 2 04 49 PM Screenshot 2022-12-30 at 2 05 34 PM Screenshot 2022-12-30 at 2 05 38 PM Screenshot 2022-12-30 at 2 05 46 PM Screenshot 2022-12-30 at 2 05 54 PM Screenshot 2022-12-30 at 2 06 05 PM Screenshot 2022-12-30 at 2 06 20 PM Screenshot 2022-12-30 at 2 06 46 PM

Safari - PASSED (Does NOT support multiple profiles; sanity checked, here)

Safari

example example example

Brave-imported profile

example example example example example example example example
Screen Shot 2022-12-30 at 7 15 06 PM Screen Shot 2022-12-30 at 7 15 10 PM Screen Shot 2022-12-30 at 7 15 14 PM Screen Shot 2022-12-30 at 7 15 17 PM Screen Shot 2022-12-30 at 7 15 24 PM Screen Shot 2022-12-30 at 7 15 42 PM Screen Shot 2022-12-30 at 7 15 52 PM Screen Shot 2022-12-30 at 7 16 06 PM

Vivaldi - PASSED

Vivaldi

example example example
Screenshot 2022-12-30 at 2 43 18 AM Screenshot 2022-12-30 at 2 44 18 AM Screenshot 2022-12-30 at 2 43 32 AM

Brave-imported profile

example example example example example example example
Screenshot 2022-12-30 at 2 22 14 AM Screenshot 2022-12-30 at 2 22 17 AM Screenshot 2022-12-30 at 2 22 28 AM Screenshot 2022-12-30 at 2 22 39 AM Screenshot 2022-12-30 at 2 22 53 AM Screenshot 2022-12-30 at 2 23 09 AM Screenshot 2022-12-30 at 2 23 27 AM

Section 5: Upgrade - PASSED

Case 1: Previous onboarding is completed - PASSED

  1. Install 1.46.144
  2. launch Brave
  3. click Skip welcome tour link
  4. new tab page shown as expected
  5. close Brave
  6. rename the profile to Brave-Browser-Beta
  7. launch Brave

Confirmed new onboarding UI is not displayed.

step 1 steps 2-3 step 4 step 7 result
Screen Shot 2022-12-28 at 10 15 54 PM Screen Shot 2022-12-28 at 10 19 24 PM Screen Shot 2022-12-28 at 10 20 42 PM Screen Shot 2022-12-28 at 10 22 50 PM Screen Shot 2022-12-28 at 10 22 20 PM

Case 2: If previous onboarding wasn't completed, show new onboarding UI - PASSED

  1. Install 1.46.144
  2. launch Brave
  3. do not click Skip welcome tour link and close Brave
  4. rename the profile to Brave-Browser-Beta
  5. launch Brave

Confirmed new onboarding UI is displayed.

step 1 step 3 result result
Screen Shot 2022-12-28 at 9 33 05 PM Screen Shot 2022-12-28 at 9 30 29 PM Screen Shot 2022-12-28 at 9 33 05 PM Screen Shot 2022-12-28 at 9 32 25 PM

Section 6: Background animations only work if hardware acceleration is disabled and "reduce motion" flag is disabled - PASSED

Case 1: Disable HW acceleration using --disable-gpu command-line arg - PASSED

  1. new profile
  2. launch Brave using --disable-gpu
  3. checked onboarding for animation

Confirmed no Brave animation during the brave://welcome onboarding screen

onboarding-without-animation

Case 2: HW acceleration enabled (default) and "reduced motion" should be checked - PASSED

  1. opened Apple -> System Preferences -> Accessibility -> Display
  2. checked Reduce motion
  3. launched Brave using a clean profile
  4. examined the brave://welcome onboarding screen

Confirmed the onboarding screen doesn't animate, when Reduce motion is on

reduce-motion

Logged issue:

Encountered issues:


Verification passed on

Brave 1.47.161 Chromium: 109.0.5414.61 (Official Build) beta (64-bit)
Revision 846c6eff1c374cde417a9cdc44193545cc07f354-refs/branch-heads/5414@{#1030}
OS Ubuntu 18.04 LTS

Section 1: New onboarding UI - brave://welcome page upon Brave launch - PASSED

  1. installed 1.47.161
  2. launched Brave
  3. verified no more first-run dialog
  4. examined new screen

Confirmed new onboarding UI is shown from brave://welcome page with Set Brave as default browser button and Skip text link as the first screen

image
image

Section 2: Single browser and single profile

Case 1: Second screen Import Settings will give users the ability to import, with most-recently-used browser set as a default import option - FAILED

Pre-requisite: Microsoft Edge installed, with a single profile with bookmarks, extensions, and saved passwords

  1. continued from Section 1
  2. clicked Set Brave as default browser
  3. examined the list of available browsers from which to import

Confirmed Microsoft Edge was available as an import option

  • Most-recently used browser was Edge, and it was not checked by default - FAILED

image

Case 2: Set Brave as default and complete import from Microsoft Edge - PASSED

  1. continued from Section 1
  2. selected Microsoft Edge
  3. clicked Import button
  4. opened brave://settings/appearance

Confirmed:

  • Setup complete screen was displayed
  • Help improve Brave screen was displayed
  • Brave is your default browser message is shown

image
image
image
image

Case 3: Verify default settings in the Help make Brave better screen - PASSED

  1. continue from Case 2
    • Help improve Brave better screen is displayed
  2. verified Send diagnostic reports if you experience a crash or freeze entry is checked as default
  3. verified Share completely private and anonymous product insights about what features are being used by Brave's users entry is checked as default
  4. clicked brave://settings/privacy link beneath the Finish button
    5.brave://settings/privacy tab opened in a separate tab
  5. confirmed Automatically send diagnostic reports setting is enabled
  6. confirmed Allow privacy-preserving product analytics (P3A) setting is enabled
  7. clicked Privacy Policy link
  8. confirmed Brave Browser Privacy Policy page opened in a new-tab ---> brave://settings/privacy
  9. return to Help improve Brave better screen and click Learn more` links

Confirmed links on the page worked as expected

image
image
image

Case 4: Verify bookmarks, extensions, and saved passwords are successfully imported from Edge - FAILED

  1. continue from Section 3:
    • Help improve Brave screen is displayed
  2. click Finish button
  3. confirmed new tab page is loaded as a first screen
  4. confirmed imported Bookmarks shown on the bookmarks bar and brave://bookmarks
  5. confirmed saved passwords shown in brave://settings/passwords
  6. confirmed history shown in brave://history

Confirmed bookmarks imported successfully

Confirmed saved passwords imported successfully

Confirmed history imported successfully

image
image
image

Case 5: Uncheck default settings in the Help make Brave better page - FAILED

  1. new profile
  2. launch Brave
  3. click Set Brave as default browser
  4. select Microsoft Edge
  5. click Import button
  6. confirmed Setup complete page shown
  7. uncheck Send diagnostic reports if you experience a crash or freeze entry
  8. uncheck Share completely private and anonymous product insights about what features are being used by Brave's users entry
  9. click Finish
  10. confirmed new tab page with imported bookmarks shown on the bookmarks bar
  11. open brave://settings/privacy in a new tab page

Confirmed Automatically send diagnostic reports setting was disabled

  • Automatically send daily usage ping to Brave was enabled

image
image

Case 6: Do not set Brave as default & do not import - PASSED

  1. new profile
  2. launch Brave
  3. click Skip on brave://welcome screen
  4. click Skip on Import Settings screen
  5. click finish
  6. new-tab page is shown
  7. go to brave://settings/getStarted

Confirmed no profile data is imported

image
image

Case 7: Set Brave as default but do not import - PASSED

  1. new profile
  2. launch Brave
  3. click Set Brave as default browser on brave://welcome screen
  4. click Skip on Import Settings screen
  5. click Finish
  6. new tab page is shown without any profile data
  7. go to brave://settings/getStarted

Confirmed Brave is your default browser message shown

image
image

Section 3 - Single browser with multiple profiles - PASSED

Case 1: Set Brave as default and import from multiple profiles - Chrome - PASSED

Prerequisite: Created 4 Profiles in Chrome with the following:

  • Profile 1: Bookmarks, Saved Passwords, Extensions, History
  • Profile 2: Bookmarks
  • Profile 3: Bookmarks
  • Profile 4: No Bookmarks
  1. new profile
  2. launch Brave
  3. click Set Brave as default browser
  4. select Chrome
  5. clicked Import
  6. confirmed all 4 profiles (Profile 1 - 4) displayed on Select profile to import modal
  7. clicked Select All to select
  8. unchecked Profile 3
  9. clicked Back
  10. navigated to Import Settings screen
  11. clicked Import again
  12. selected Profiles 1, 2, & 4
  13. clicked Import profiles
  14. confirmed Setup Complete confirmation screen shown
  15. click Finish
  16. new tab page shown with bookmarks on the bookmarks bar

Confirmed Saved passwords from Profile 1 are successfully imported

Confirmed Bookmarks from Profile 1 and 2 are successfully imported

image
image
image
image
image
image

Case 2: Do not set Brave as default but import profile data - PASSED

  1. new profile
  2. launch Brave
  3. click Skip on brave://welcome screen
  4. click Import on Import Settings screen
  5. check Chrome
  6. check the checkbox for Chrome Profile 2
  7. click the Import profiles button
  8. click Finish
  9. go to brave://settings/getStarted

Confirmed new tab page shown with imported profile data (bookmarks)

image

Case 3: Set Brave as default and Skip import from onboarding UI, but proceed to import from brave://settings/importData - PASSED

  1. new profile
  2. launch Brave
  3. click Set Brave as default browser
  4. click Skip
  5. click Finish
  6. verified new tab page opened as expected
  7. open brave://settings/getStarted
  8. confirm Brave is your default browser
  9. open brave://settings/importData
  10. select Chrome Profile 1
  11. click Import

Confirmed bookmarks are imported and shown in the Bookmarks side panel

image
image
image

Section 4: Multiple browsers, each with multiple profiles - PASSED

Case 1: Verify all installed non-Brave browsers are shown in the Import Settings page - PASSED

Prerequisites:

  • Have import supported browsers installed:
    Chrome, Chrome Beta, Chrome Dev, Edge, Firefox and Vivaldi
  1. new profile
  2. launch Brave
  3. click Set Brave as default browser button on brave://welcome page
  4. Confirmed Chrome, Edge, Firefox and Vivaldi browsers were listed

image

Case 2: Do not show all Chrome channels in the Select profile to import screen when Chrome (stable) is selected in the Import Settings screen - FAILED

  1. new profile
  2. launch Brave
  3. click the Set Brave as default browser button on brave://welcome page
  4. select Chrome
  5. click Import
  • Profiles from `Chrome (beta) and (dev) channels also displayed.

image

Case 3: Set Brave as default and import from multiple browsers with multiple profiles - select individually - FAILED

Create 4 Firefox profiles:
Profile 1: Bookmarks, Extensions, Saved passwords
Profile 2: Bookmarks, Extensions
Profile 3: Bookmarks
Profile 4: No data

  1. new profile
  2. launch Brave
  3. click Set Brave as default browser button on brave://welcome page
  4. select Mozilla Firefox on Import Settings screen
  5. click Import
  6. click Select All
  7. click Import profiles
  8. click Finish

Confirmed bookmarks were imported from all 4 Firefox profiles

Failed to import extensions due to #27487 (will re-test)

Failed to find one of the profiles - logged #27561 (which now works)

Failed to import passwords from Profile 1

Chrome Stable - PASSED

Profile 1: Bookmarks, Saved passwords, Extensions
Profile 2: Bookmarks
Profile 3: No Data
Profile 4: Bookmarks
Profile 5: Bookmarks

  1. new profile
  2. launch Brave
  3. click Set Brave as default browser
  4. select Chrome
  5. click Import
  6. click Select All and unselect Chrome Person 2
  7. click Import profiles
  8. click Finish

Confirmed Bookmarks, saved passwords are successfully imported from Profile 1

Confirmed Bookmarks from Profiles 4 & 5 are imported

Confirmed Profile 2 data is unchecked, so no data is imported

image
image
image
image
image
image

Case 4: Set Brave as default and import from multiple browsers with multiple profiles (where supported) - simultaneously - FAILED

Firefox - FAILED

Firefox

image

Confirmed bookmarks imported

image

Failed to import passwords

Failed to import extensions

Encountered:

Chrome Beta - PASSED

Chrome Beta

Brave-imported profile

image
image
image

Vivaldi - PASSED

Vivaldi

Brave-imported profile

image
image

Section 5: Upgrade - PASSED

Case 1: Previous onboarding is completed - PASSED

  1. Install 1.46.144
  2. launch Brave
  3. click Skip welcome tour link
  4. new tab page shown as expected
  5. close Brave
  6. rename the profile to Brave-Browser-Beta
  7. launch Brave

Confirmed new onboarding UI is not displayed.

image

Case 2: If previous onboarding wasn't completed, show new onboarding UI - PASSED

  1. Install 1.46.144
  2. launch Brave
  3. do not click Skip welcome tour link and close Brave
  4. rename the profile to Brave-Browser-Beta
  5. launch Brave

Confirmed new onboarding UI is displayed.

image

Section 6: Background animations only work if hardware acceleration is disabled and "reduce motion" flag is disabled - PASSED

Case 1: Disable HW acceleration using --disable-gpu command-line arg - PASSED

  1. new profile
  2. launch Brave using --disable-gpu
  3. checked onboarding for animation

Confirmed no Brave animation during the brave://welcome onboarding screen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants