Upgrade from Chromium 117 to Chromium 118 #19765

….0.5993.21.

The method `IsSyncFeatureEnabled` has been removed from `SyncServiceSetup`, and this info is now supposed to be retrieved from the `SyncService` instance now. Chromium change: https://chromium.googlesource.com/chromium/src/+/131de005c97ae2d50679d83b7a80f36bf04c157d commit 131de005c97ae2d50679d83b7a80f36bf04c157d Author: Marc Treib <[email protected]> Date: Thu Aug 10 08:35:09 2023 +0000 Cleanup: Remove SyncSetupService usage from passwords_mediator SyncSetupService is a thin wrapper around the actual SyncService, and we're working to get rid of it. The one usage in passwords_mediator.mm could be trivially moved to the actual SyncService instead, which was already available anyway. This also lets us remove one no-longer-used method from SyncSetupService. Bug: 1438800

The token that was being used for replacement got removed, and a different token had to be used in its place. Chromium change: https://chromium.googlesource.com/chromium/src/+/92cee5b6beedd6942ad4082a56c0378a087ce7a7 commit 92cee5b6beedd6942ad4082a56c0378a087ce7a7 Author: Chris Fredrickson <[email protected]> Date: Thu Aug 10 16:57:38 2023 +0000 Use PassKey to limit scope of private access into SchemefulSite

This is a simple change to the instantiation of `net::ParsedCookie` for the VPN services, passing a default value for the new block truncated flag. Chromium change: https://chromium.googlesource.com/chromium/src/+/a1eada603b3f0bb0eb7aa0617039fb4c1cff11f0 commit a1eada603b3f0bb0eb7aa0617039fb4c1cff11f0 Author: Andrew Williams <[email protected]> Date: Wed Aug 9 03:31:12 2023 +0000 [Cookies] Add support for blocking truncated cookies Adds the code needed to block truncated cookies behind a feature flag (currently disabled). This also plumbs the value such that this can be controlled by an enterprise policy. This is part of a chain of CLs updating the cookie handling logic to ignore truncated cookies. The following prototype CL shows all of the planned changes in one place: https://chromium-review.googlesource.com/c/chromium/src/+/4134025 Bug: 1233602

This override is a bit annoying, as it tends to be necessary to replicate it on several places making use of `unified_side_panel`. This change adds the substitution to `BrowserViewTest`. Chromium change: https://chromium.googlesource.com/chromium/src/+/30979a2bb43c101a3b694cd66915271520fe4f73 commit 30979a2bb43c101a3b694cd66915271520fe4f73 Author: Caroline Rising <[email protected]> Date: Mon Aug 14 18:12:21 2023 +0000 Add a rounded corner to the top of the page content when the side panel is open. The corner takes the color of the toolbar/side panel border and has a rounded stroke matching the content separators. screenshot: https://screenshot.googleplex.com/8os3s6Bs3ZJhaKa Bug: 1399966

This is merely a fix on the header's path. Chromium change: https://chromium.googlesource.com/chromium/src/+/280c58a0e1a45a862d0a5dfd364ad3379b7b36f6 commit 280c58a0e1a45a862d0a5dfd364ad3379b7b36f6 Author: Avi Drissman <[email protected]> Date: Wed Aug 16 16:27:55 2023 +0000 Move OSStatus logging to base/apple Bug: 1444927

This header has been moved upstream under an apple path. Chromium change: https://chromium.googlesource.com/chromium/src/+/2b19128cca48c8e113c7a5c0150877e397834925 commit 2b19128cca48c8e113c7a5c0150877e397834925 Author: Avi Drissman <[email protected]> Date: Wed Aug 16 00:39:49 2023 +0000 Move scoped_objc_class_swizzler to base/apple Bug: 1444927

This affects brave merely on the inclusion of headers and the renaming of the feature flag access itself. Chromium change: https://chromium.googlesource.com/chromium/src/+/b601bb010bfa9788df1cd27593db0c31b19a9884 commit b601bb010bfa9788df1cd27593db0c31b19a9884 Author: Patricia Alfonso <[email protected]> Date: Wed Aug 16 21:09:40 2023 +0000 [DIPS] move dips_features to //content/public As a first step to moving the entire dips project to //content, move the feature flag to //content. Bug: 1399545

Changes upstream to one of the args for `InitializeWithHost` had to applied to our own overrides, to pass a new argument through. Chromium change: https://chromium.googlesource.com/chromium/src/+/01d003e4e7160eefbb8278ffefd13413f653b19f commit 01d003e4e7160eefbb8278ffefd13413f653b19f Author: Bo Liu <[email protected]> Date: Wed Aug 16 19:46:50 2023 +0000 gpu: Refactor load program binary shm flag This is a refactor that does not intend to change behavior, but prepares for fixing logic for deleting shader cache if shader loading fails. Motivation is making ActivityFlags since there can be multiple GPU threads that load shaders now. ActivityFlags has only ever had one flag since its inception years ago. So just remove the support for multiple flags and just turn it into a count that's incremented atomically. Switch to using std::atomic since base::subtle::Atomics is deprecated. Rename everything from "activity flags" to "use shader cache shm count". Bug: 1470074

Upstream has been moving a lot of code under the `mac` namespace to a new `apple` namespace, and with that files are being moved around. Chromium changes: https://chromium.googlesource.com/chromium/src/+/e80be15ed013b6132ff4bb37c2b79537725961d9 commit e80be15ed013b6132ff4bb37c2b79537725961d9 Author: Avi Drissman <[email protected]> Date: Fri Aug 18 18:34:47 2023 +0000 Remove forwarding headers Now that Crashpad is rolled, remove the forwarding headers. Fixed: 1444927 https://chromium.googlesource.com/chromium/src/+/eac566b06085a41c6910b204bb2afe38752ced4d commit eac566b06085a41c6910b204bb2afe38752ced4d Author: Avi Drissman <[email protected]> Date: Fri Aug 18 02:56:21 2023 +0000 Move foundation_util to base/apple, leave a forwarding header Crashpad is not yet updated for the new location, so leave a forwarding header to be removed later. Skipping trybots. This is a Mac change, and it’s passing all trybots except for android_optional_gpu_tests_rel that is repeatedly failing on an unrelated issue. NOTRY=true Bug: 1444927 https://chromium.googlesource.com/chromium/src/+/a09d7dda2e1278b9ba903c3c5f459ace3cadb87c commit a09d7dda2e1278b9ba903c3c5f459ace3cadb87c Author: Avi Drissman <[email protected]> Date: Thu Aug 17 16:26:58 2023 +0000 Move scoped_cftypreref to base/apple, leave a forwarding header Crashpad is not yet updated for the new location, so leave a forwarding header to be removed later. Bug: 1444927

This is a change only to the path of these headers. Chromium change: https://chromium.googlesource.com/chromium/src/+/101f4cc62642c7fbf80e20e10fc3bd3811a555e9 commit 101f4cc62642c7fbf80e20e10fc3bd3811a555e9 Author: David Roger <[email protected]> Date: Fri Aug 18 09:59:33 2023 +0000 [profiles] Move profile code to c/b/ui/profiles # Moved from c/b/ui/signin: profile_colors_util.cc profile_colors_util.h profile_colors_util_unittest.cc profile_customization_bubble_sync_controller.h profile_customization_synced_theme_waiter.cc profile_customization_synced_theme_waiter.h profile_customization_synced_theme_waiter_unittest.cc profile_customization_util.cc profile_customization_util.h profile_customization_util_unittest.cc # Moved from c/b/ui: profile_error_browsertest.cc profile_error_dialog.cc profile_error_dialog.h profile_picker.cc profile_picker.h profile_picker_unittest.cc profile_ui_test_utils.h profile_view_utils.cc profile_view_utils.h signin_intercept_first_run_experience_dialog.cc signin_intercept_first_run_experience_dialog.h signin_intercept_first_run_experience_dialog_browsertest.cc Change-Id: I4b6a769296ae2059734086706e6a2d7349407e21

Chromium change: https://chromium.googlesource.com/chromium/src/+/593dba218a73af608038e70f7e7c9183dfda440f commit 593dba218a73af608038e70f7e7c9183dfda440f Author: Zack Han <[email protected]> Date: Fri Aug 18 15:07:23 2023 +0000 [Settings] Link help center articles to enhanced protection page - Adds a string for the "learn more" message under enhanced protection - Links the info icon to another safe browsing page when the feature flag is on Screenshots(before): https://crbug.com/1431538#c5 Screenshots(after): https://crbug.com/1431538#c6 Bug: 1431538, 1431533

This file is now part of the content layer. Chromium change: https://chromium.googlesource.com/chromium/src/+/31154961f51fd2c1116e37fbc7e2f0ea6099414e commit 31154961f51fd2c1116e37fbc7e2f0ea6099414e Author: Aman Verma <[email protected]> Date: Fri Aug 18 10:48:25 2023 +0000 Move native_web_keyboard_event.h to //content/common/input This refactoring is a part of bigger project to handle input on viz thread (go/input-on-viz). We are moving input related interfaces that RenderWidgetHostImpl uses to //content/common/input. This would provide a single stack in //content/common/input that we quickly enter in either the browser or GPU viz which would allow for relatively clean movement of code. GPU process can link in the same input stack and forward the data to the renderer using the same code. This change also renames skip_in_browser to skip_if_unhandled. AX-Relnotes: n/a Bug: 1472313, b/294817120

Upstream has changed the arguments for `IsCreditCardUploadEnabled`, which we happen to stub out in brave, to deactivate these experiments, and this fixes corrects the signature for our stubs. Upstream has also changed the enum metrics to another namespace, and this has to be reflected on the overriden tests we have to make sure that these experiments are off. Chromium change: https://chromium.googlesource.com/chromium/src/+/f0ce5de122756cd5ea10018bfd520fb911177d80 commit f0ce5de122756cd5ea10018bfd520fb911177d80 Author: Florian Leimgruber <[email protected]> Date: Mon Aug 21 08:40:31 2023 +0000 Rename metrics-only APIs related to sync sign-in state. For the sync deprecation, the Sync team is auditing all calls to their APIs. This CL simplifies their job by marking metrics-only usages around the sync sign-in state as such. No behavior changes. This CL is a fork of crrev.com/c/4750260. See the description of that CL for additional reasons why this is desirable. Specifically, this CL does the following: - Renames the very generic PDM::GetSyncSigninState() to GetPaymentsSigninStateForMetrics(). It turns out that almost all calls are for metrics purposes - modulo the exceptions explained below. This is the majority of this CL's delta. - Moves AutofillSyncSigninState from sync_utils to AutofillMetrics::PaymentsSigninState. - Adds PDM::IsPaymentsWalletSyncTransportEnabled(). Turns out that all non-metrics uses of PDM::GetSyncSigninState() are checking if wallet is running in transport mode. There are only three uses of this function, which the Sync team can audit separately. Bug: 1462286

Chromium change: https://source.chromium.org/chromium/chromium/src/+/ec882ef9f52465753775403a652150e411eb25d2 commit ec882ef9f52465753775403a652150e411eb25d2 Author: Xiaodan Zhu <[email protected]> Date: Thu Aug 17 19:16:20 2023 +0000 Revert "cros_next: Revert window caption bar size changes" This reverts commit eaad16c6e9f8596f6be59515d904cd2ee65f6abc. Reason for revert: Rounded corner is added so we can re-apply the layout change. Original change's description: > cros_next: Revert window caption bar size changes > > Since the rounded window corner radius updates are not able to meet the > M116 timeline, revert the window caption bar size changes which were > originally made for the rounded window. Here's the link for the > original CL: https://chromium-review.googlesource.com/c/chromium/src/+/4222272 > > Bug: b/267192501 > Change-Id: Ied6eecda0c71f98f21cb53638ee85a8e4ea7218a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4557260 > Reviewed-by: Peter Kasting <[email protected]> > Commit-Queue: Peter Kasting <[email protected]> > Reviewed-by: Xiyuan Xia <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1148166} Bug: b/267192501

Chromium change: https://source.chromium.org/chromium/chromium/src/+/a50d3aca43ba4171c230c58c811834b5b2a3de54 commit a50d3aca43ba4171c230c58c811834b5b2a3de54 Author: Antonio Maiorano <[email protected]> Date: Mon Aug 21 17:53:42 2023 +0000 Reland "Add DXC DLLs to Chrome installer" This is a reland of commit ab0deff7f8ad0a776b106baf1a7d2c3b54a9a540 What has changed from the initial CL: added dxcompiler.dll to the CETCOMPAT_NOT_REQUIRED list in checkbins.py for now, until crbug.com/1473950 is resolved. Original change's description: > Add DXC DLLs to Chrome installer > > This adds 2 files, dxcompiler.dll and dxil.dll, to the installer if > GN arg `dawn_use_built_dxc` is true. > > * dxcompiler.dll is the core DXC library, and is built from source by > Dawn when `dawn_use_built_dxc` is true (currently false for Chrome). > > * dxil.dll is Microsoft's DXIL signing DLL. When `dawn_use_built_dxc` > is true, the latest version of this file is copied from the platform > SDK. > > Note that the main reason for building dxcompiler.dll from source > rather than using official releases from Microsoft is that it allows us > to address security issues more quickly. > > Note that renaming dxcompiler.dll to something else in order to clarify > that it is not the official MS version was considered; however, renaming > it breaks the CLI tool dxc.exe. Instead, the metadata for the DLL will > clearly state that it is a DLL built for Google Dawn. > > Note that after this lands, the plan is to do a Finch trial where some > Chrome instances will use DXC, while others use FXC. The plan is to set > dawn_use_built_dxc to true in Chrome, and use a Finch flag to drive > Dawn's "use_dxc" flag. If all goes well with the trial, we will remove > dawn_use_built_dxc as it will become the default. > > Bug: dawn:1862 > Change-Id: I65961468663db252cbdf9960d69c13a7426de771 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4633008 > Commit-Queue: Antonio Maiorano <[email protected]> > Reviewed-by: Greg Thompson <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1184743} Bug: dawn:1862 Bug: chromium:1473950

…mac/) Chromium change: https://source.chromium.org/chromium/chromium/src/+/5289ab25451e3630ecc4f7441ec3ffa330d112e1 commit 5289ab25451e3630ecc4f7441ec3ffa330d112e1 Author: Avi Drissman <[email protected]> Date: Wed Aug 16 23:13:22 2023 +0000 Move scoped_nsautorelease_pool to base/apple, leave a forwarding header Crashpad is not yet updated for the new location, so leave a forwarding header to be removed later. Bug: 1444927

Chromium change: brave/chromium@40f1152 [UPMCleanup] Remove branding checks from Touch-to-Fill For all the "modern" variants we now drop "modern" from the name as they are the only remaining versions. The only exception is the favicon size since both sizes are used in the new version. Bug crbug.com/1472327 was filed to sort that out. Bug: 1439191

The WebUIMochaSuccessFailureWithoutTestLoaderTest.* tests were failing with the following error message: Refused to load the script 'chrome://webui-test/mocha.js' because it violates the following Content Security Policy directive: "script-src chrome://resources chrome://test 'self'". Note that 'script-src-elem' was not explicitly set, so 'script-src' is used as a fallback. Added chrome://webui-test to relevant CSP and updated code to better match upstream.

The case of this identifier was changed over a number of refactoring commits, with the below commit being the final one. Chromium change: https://source.chromium.org/chromium/chromium/src/+/4349c2927240b296ba918390369ecfa2440e31b2 commit 4349c2927240b296ba918390369ecfa2440e31b2 Author: Fiona Macintosh <[email protected]> Date: Fri Aug 18 13:48:12 2023 +0000 Settings: Logic for hiding preloading subpage on cookies page. Logic gated behind isPerformanceSettingsPreloadingSubpageEnabled flag. Bug: b:296212999

The return type for `BuildServiceInstanceForBrowserContext` is a `unique_ptr`, which requires changes to our overrides for it. Chromium change: https://chromium.googlesource.com/chromium/src/+/0de3988c3473ba07018d720967496aab417d963b commit 0de3988c3473ba07018d720967496aab417d963b Author: Arthur Milchior <[email protected]> Date: Tue Aug 22 03:08:04 2023 +0000 Implement the non-deprecated builder. Any class inheriting `BrowserContextKeyedServiceFactory` should implement either `BuildServiceInstanceForBrowserContext` or `BuildServiceInstanceFor`. The second one was deprecated, this CL replaces it with the first one. Bug: 1396138

This is a simple change for the namespace depth only. Chromium change: https://chromium.googlesource.com/chromium/src/+/28154a6fbbcaa037ae8692d96bc114286c57f6c7 commit 28154a6fbbcaa037ae8692d96bc114286c57f6c7 Author: Avi Drissman <[email protected]> Date: Tue Aug 22 04:06:45 2023 +0000 Move ScopedTypeRef and ScopedCFTypeRef into base::apple:: This moves these two types into the base::apple:: namespace. This also rolls Crashpad: Update Crashpad to a736f7d070c872a4cc786c31755fd769fb2e50b3 50ce1550a1ca [fuchsia] Move //zircon/public/lib/zx to //zircon/system/ulib/zx a736f7d070c8 Roll mini_chromium putting /base/apple files into base::apple:: Fixed: 1474628

Chromium change: https://chromium.googlesource.com/chromium/src/+/2782f1a0c8e3e84c0e11a6e5f12e58811c442a9d commit 2782f1a0c8e3e84c0e11a6e5f12e58811c442a9d Author: David Yeung <[email protected]> Date: Fri Aug 25 21:22:32 2023 +0000 [CR2023] Page Info dialog does not respect security information view. Buttons were getting cut off in the PageInfo dialog. Fix is to make sure PageInfo uses the max child view width (in this case, the security information view). https://screenshot.googleplex.com/s7bSAkGNJyR65g2 Bug: 1475059

Chromium change: https://chromium.googlesource.com/chromium/src/+/79ca9265d25f26dd9dc3c8fad2a72241054e14ae commit 79ca9265d25f26dd9dc3c8fad2a72241054e14ae Author: Henrique Ferreiro <[email protected]> Date: Wed Aug 23 10:17:33 2023 +0000 Simplify the build for branded strings Branded strings are defined in *chromium_strings.grd and *google_chrome_strings.grd files. Both kind of files contain different messages for the same ids. Those ids are compiled into generated header files by their corresponding targets. Both the targets and the header files are named differently, similarly to the grd files. This requires that the correct target and header file is used depending on the build but, in practice, most code sites just depend on both targets and include both header files. This CL merges those targets so that from now on only the chromium version is used (e.g. //chrome/app:chromium_strings and chrome/grit/chromium_strings.h, //components/strings/component_chromium_strings and components/strings/grit/components_chromium_strings.h, etc.). The targets are parameterized by `branding_path_product` so that the correct grd and pak filenames are used. Future CLs will change the targets and generated files to be named *branded_strings. Bug: 1470725

Upstream has renamed the previous function to indicate that it checks for the use of `kProfilesReordering`. commit bec8a26a164ccf0aa8e60c2a79918d433fa3af33 Author: Ryan Sultanem <[email protected]> Date: Fri Aug 25 09:05:06 2023 +0000 [Profile Reordering] Sorted profiles check to use the feature param Currently there exist two ways to get the sorted profiles, eitehr by local profile name or by 'name'. The goal of this CL is to have both redirect to the user order when the feature is on. We want the new order to be used everywhere when the feature will be on. Bug: 1466146

Upstream has been changing the signature of some factory function to return a unique_ptr, rather than a raw pointer. This change corrects our override for the builder method. Chromium change: https://chromium.googlesource.com/chromium/src/+/46b9a1849245d87467910da742a2f910bc237362 commit 46b9a1849245d87467910da742a2f910bc237362 Author: Arthur Milchior <[email protected]> Date: Thu Aug 24 14:59:35 2023 +0000 Implement the non-deprecated builder. Any class inheriting `BrowserContextKeyedServiceFactory` should implement either `BuildServiceInstanceForBrowserContext` or `BuildServiceInstanceFor`. The second one was deprecated, this CL replaces it with the first one. Bug: 1396138

Upstream has been changing the signature of some factory function to return a unique_ptr, rather than a raw pointer. This change corrects our override for the builder method. Chromium change: https://chromium.googlesource.com/chromium/src/+/f4997f118db375600291c698e9f2ea8fd12fe73a commit f4997f118db375600291c698e9f2ea8fd12fe73a Author: Arthur Milchior <[email protected]> Date: Tue Aug 22 09:15:26 2023 +0000 Implement the non-deprecated builder. Any class inheriting `BrowserContextKeyedServiceFactory` should implement either `BuildServiceInstanceForBrowserContext` or `BuildServiceInstanceFor`. The second one was deprecated, this CL replaces it with the first one. Bug: 1396138

Upstream has been changing the signature of some factory function to return a unique_ptr, rather than a raw pointer. This change corrects our override for the builder method. Chromium change: https://chromium.googlesource.com/chromium/src/+/22de750a0a7d2346daa56447366e5f9dd3373ae6 commit 22de750a0a7d2346daa56447366e5f9dd3373ae6 Author: Arthur Milchior <[email protected]> Date: Tue Aug 22 12:25:04 2023 +0000 Migrate GAIAInfoUpdateServiceFactory to a new builder method Any class inheriting `BrowserContextKeyedServiceFactory` should implement either `BuildServiceInstanceForBrowserContext` or `BuildServiceInstanceFor`. The second one was deprecated, this CL replaces it with the first one. Bug: 1396138

The substitution for `GetBrowserContextToUse` got dropped due to a recent change, and this change reanchors this override to another method. Chromium change: https://chromium.googlesource.com/chromium/src/+/0e8dbbf992ff0f30184628473ea6775a70eb0283 commit 0e8dbbf992ff0f30184628473ea6775a70eb0283 Author: Arthur Milchior <[email protected]> Date: Tue Aug 22 16:37:48 2023 +0000 Implement the non-deprecated builder. Any class inheriting `BrowserContextKeyedServiceFactory` should implement either `BuildServiceInstanceForBrowserContext` or `BuildServiceInstanceFor`. The second one was deprecated, this CL replaces it with the first one. Bug: 1396138

This is a simple replacement of the method being used to ground our substitutions. Chromium change: https://chromium.googlesource.com/chromium/src/+/e46d92d1e56e12e251849b6bc91d81092510fb1d commit e46d92d1e56e12e251849b6bc91d81092510fb1d Author: Thomas Lukaszewicz <[email protected]> Date: Fri Aug 25 23:58:08 2023 +0000 [color] Remove BrowserFrame::SelectNativeTheme() BrowserFrame::SelectNativeTheme() was originally added to support the BrowserFrame's NativeTheme changing when browser themes were toggled on/off. This was necessary as themes were painted in light mode, and if the browser theme was toggled off and the Browser needed to revert to dark mode, the dark NativeTheme instance was required to be set. This is no longer necessary as dark mode is now controlled through the ColorProviderKey::ColorMode bit, which is independent of the hierarchy's NativeTheme. Bug: 1472289

This function has had its signature changed with an extra argument, which just gets passed along to the original implementation by the override we have. Chromium change: https://chromium.googlesource.com/chromium/src/+/5fcb41fb2b1b04be430dc3ebb0e823dc3f0d1562 commit 5fcb41fb2b1b04be430dc3ebb0e823dc3f0d1562 Author: Sarah Criel <[email protected]> Date: Fri Aug 25 12:46:18 2023 +0000 Implement red interstitial facelift color and icon changes This first CL for implementing the red interstitial facelift changes the color scheme to the GM3 standard error/primary colors. It also implements the main interstitial page icon and Desktop omnibox/page info icon changes behind the feature flag. Bug: 1469647

This function has been split into two functions. The version we use in this particular case is the one that defaults to the user's localisation, and the code has been changed accordingly. Chromium change: https://chromium.googlesource.com/chromium/src/+/2cd4fecfd9e8cbddbe3c89745302eef439168cf4 commit 2cd4fecfd9e8cbddbe3c89745302eef439168cf4 Author: Peter Kasting <[email protected]> Date: Sat Aug 26 14:40:29 2023 +0000 Split TimeFormatWithPattern() into localized and non-localized cases. This provides more clarity about what the localized version actually does, and the non-localized version will be useful to clean up callers who currently manually explode times (e.g. to format via StringPrintf). Bug: 1476086

Upstream has removed the baseline type from being a member of `TextMetrics`, and now it has individual members that can be called straight from `TextMetrics`. This change corrects our access of it. Chromium change: https://chromium.googlesource.com/chromium/src/+/159eaad150cc332332d76189997befe3d1254d1b commit 159eaad150cc332332d76189997befe3d1254d1b Author: Yi Xu <[email protected]> Date: Fri Aug 25 05:13:59 2023 +0000 Implement baselines attributes for TextMetrics According to the WHATWG spec, https://html.spec.whatwg.org/multipage/canvas.html#textmetrics, TextMetrics has 3 baseline attributes, alphabeticBaseline, hangingBaseline and ideographicBaseline, which are missing in our current implementation. This cl implements these baseline attributes. The intend to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/AORzxU_ZNTk/m/Iw5E8lGlAgAJ Bug: 1473117

This function is not for the test use, but it is necessary the stubbing of it to be provided, so the fake can be instantiated. Chromium change: https://chromium.googlesource.com/chromium/src/+/4eea7758f8996bc6355aac8eea582f42c0d5f772 commit 4eea7758f8996bc6355aac8eea582f42c0d5f772 Author: Daniel Rubery <[email protected]> Date: Thu Aug 24 22:06:29 2023 +0000 Expose method on DownloadDisplayController to show the security subpage This CL adds a method to open the security subpage on the DownloadDisplayController. This allows code outside of //c/b/ui/views/download to pop open the security subpage view. This is useful in a couple of cases for deep scanning (see dependent CLs) Bug: 1466284

This is merely a change in path for these inclusions/target. Chromium change: https://chromium.googlesource.com/chromium/src/+/7f06d09e7e5f8b0e1fc6ff13a322c538876fa5c0 commit 7f06d09e7e5f8b0e1fc6ff13a322c538876fa5c0 Author: Gauthier Ambard <[email protected]> Date: Tue Aug 22 16:30:48 2023 +0000 [iOS] Move ios/c/b/application_context to model subfolder To simplify the folder hierarchy on iOS and have a clearer layer separation, all the files in ios/c/b/<foo>/ will be moved to ios/c/b/<foo>/model/ to showcase that they are model files. Bug: 1319852

This is merely a change to the inclusion paths for the files/target. Chromium change: https://chromium.googlesource.com/chromium/src/+/caf0394afe0a70641476d4d80c90bd3b9740b774 commit caf0394afe0a70641476d4d80c90bd3b9740b774 Author: Gauthier Ambard <[email protected]> Date: Wed Aug 23 08:06:07 2023 +0000 [iOS] Move ios/c/b/bookmarks to model subfolder To simplify the folder hierarchy on iOS and have a clearer layer separation, all the files in ios/c/b/<foo>/ will be moved to ios/c/b/<foo>/model/ to showcase that they are model files. Bug: 1319852

The very use made by brave was a mirror of what was being done upstream, and was deleted in the same manner. Chromium change: https://chromium.googlesource.com/chromium/src/+/7ed16dfedfb1157c24c5823a9788c821290debd3 commit 7ed16dfedfb1157c24c5823a9788c821290debd3 Author: Daniel White <[email protected]> Date: Fri Aug 25 13:09:30 2023 +0000 [iOS] Removed ChromeBrowserStateRemovalController The removal of the ChromeBrowserStateRemovalController file marks the conclusion of Chrome on iOS' effort to migrate to a single profile architecture. Fixed: 1473902

Upstream has deleted a few rust third_party deps still used by brave. This change copies those changes into brave's third_party folder, and corrects the pathing in the gn files. Chromium change: https://chromium.googlesource.com/chromium/src/+/1293667fe4263ee9b1a546ab5a6916c5fc356390 commit 1293667fe4263ee9b1a546ab5a6916c5fc356390 Author: Collin Baker <[email protected]> Date: Mon Aug 28 17:09:40 2023 +0000 Remove third_party/rust gnrt dependencies gnrt was moved to a Cargo-managed build and no longer uses vendored crates in third_party/rust. Remove the crates not used elsewhere. Bug: 1475069

This pref has been made obsolete, and removed. Utimately, this pref was already no-op on current code. Chromium change: https://chromium.googlesource.com/chromium/src/+/15a343d8ce5ae8a0d54c43c520b2d6b776f3d9f9 commit 15a343d8ce5ae8a0d54c43c520b2d6b776f3d9f9 Author: Mariam Ali <[email protected]> Date: Mon Aug 28 15:56:50 2023 +0000 Clean-up: Remove old prefs Remove year old prefs from cleanup. Bug: none

To new structs have been added to permission, to allow the passing of data around as a bundle, for cases where data is held in common with multiple functions. This change corrects our own overrides, to properly handle these data structs, specially in cases where copy of data is required, as these structs are move-only. Chromium change: https://chromium.googlesource.com/chromium/src/+/0a6d4b5069e7b517833dcc014c79e1e5caab7f83 commit 0a6d4b5069e7b517833dcc014c79e1e5caab7f83 Author: Andy Paicu <[email protected]> Date: Tue Aug 29 15:13:09 2023 +0000 [PEPC] Add new structs to contain permission request data This CL adds new struct PermissionRequestDescription and PermissionRequestData that groups all information we will need to make a permission request to permission infrastructure. This is one in a series of CLs implementing the design: https://docs.google.com/document/d/1a1gjlJ4VkAWoG8AeGKZDcQXm_c0q-cFTs_5MxmjWVYI/edit, next step is to parse the fields within the structs handle permission request from <permission> element properly. Bug: 1271543,1462930

Chromium change: https://chromium.googlesource.com/chromium/src/+/83d6056f42a0a2cee0bc885b8baf72f99e86cb19 commit 83d6056f42a0a2cee0bc885b8baf72f99e86cb19 Author: Elly <[email protected]> Date: Mon Aug 28 19:55:03 2023 +0000 ui: simplify TreeModelObserver In particular: * Remove support for batched updates from the observer interface; the TreeModel class itself does not support these so in practice only updates of size 1 can be observed * Give the observer methods empty default bodies * Simplify some logic in TreeView, since it no longer needs to account for possible batched updates to its TreeModel Bug: None

Chromium change https://chromium.googlesource.com/chromium/src/+/e83ad48b7de16798e682a50ab68f5fcb3f09b3f9 commit e83ad48b7de16798e682a50ab68f5fcb3f09b3f9 Author: sbingler <[email protected]> Date: Mon Aug 28 18:57:04 2023 +0000 Allow partitioned storage by default when 3p cookies are disabled Blocking third-party cookies by default (ex: through the toggle in a new incognito tab) currently disabled all third-party storage as well. This CL allows access to partitioned storage when third-party cookies are disabled by default. This only applies when third-party cookies are disabled by default across all urls. If cookies are disabled through a user specified rule/pattern then storage will continue to be disabled as well. Bug: 1453783

The function being called by the override has added a new argument, which has to be checked before being passed. Chromium change: https://chromium.googlesource.com/chromium/src/+/7d3ed7e22b05b6e254a49c0cc061414561afe207 commit 7d3ed7e22b05b6e254a49c0cc061414561afe207 Author: David Bertoni <[email protected]> Date: Tue Aug 29 02:11:56 2023 +0000 [Extensions] Track signaled requests in per-BrowserContext map. The data for tracking signaled requests was initially moved into a global singleton. This CL moves this tracking into the per- BrowserContext data object, since request IDs are unique to a particular BrowserContext. There is no behavior change expected with this CL. Bug: 1433136

Chromium change: https://chromium.googlesource.com/chromium/src/+/32fb357813defee20adf86ecaa5f837d6debc7cb commit 32fb357813defee20adf86ecaa5f837d6debc7cb Author: Dustin J. Mitchell <[email protected]> Date: Wed Aug 23 22:50:24 2023 +0000 Set CARGO_MANIFEST_DIR when building Rust This is previously set invocations of `build.rs`, but also needs to be set during the main build, as it is often used via `env!(..)` in source files. Bug: 1455145

Chromium change: https://source.chromium.org/chromium/chromium/src/+/1293667fe4263ee9b1a546ab5a6916c5fc356390 commit 1293667fe4263ee9b1a546ab5a6916c5fc356390 Author: Collin Baker <[email protected]> Date: Mon Aug 28 17:09:40 2023 +0000 Remove third_party/rust gnrt dependencies gnrt was moved to a Cargo-managed build and no longer uses vendored crates in third_party/rust. Remove the crates not used elsewhere. Bug: 1475069

Chromium changes: brave/chromium@f300646 [Tab Switcher] Remove isGridTabSwitcherEnabled Now that M117 is branched and TabGroupsContinuationAndroid is the default everywhere the old flags for the initial development of the Grid Tab Switcher can finally be cleaned up. This is the fourth step which removes the isGridTabSwitcherEnabled method everywhere. As a result there are also a number of cascading side effects in distant files. Bug: 1466158 brave/chromium@9724e9d [Tab Switcher] Remove isTabGroupsAndroidEnabled Now that M117 is branched and TabGroupsContinuationAndroid is the default everywhere the old flags for the initial development of the Grid Tab Switcher can finally be cleaned up. This is the fifth step which removes the isTabGroupsAndroidEnabled method everywhere. As a result there are also a number of cascading side effects outside the tab switcher proper. Bug: 1466158

Otherwise there is error on BACKGROUND_SYNC being re-defined. Chromium change: brave/chromium@0a6d4b5 [PEPC] Add new structs to contain permission request data This CL adds new struct PermissionRequestDescription and PermissionRequestData that groups all information we will need to make a permission request to permission infrastructure. This is one in a series of CLs implementing the design: https://docs.google.com/document/d/1a1gjlJ4VkAWoG8AeGKZDcQXm_c0q-cFTs_5MxmjWVYI/edit, next step is to parse the fields within the structs handle permission request from <permission> element properly. Bug: 1271543,1462930

Chromium change: https://source.chromium.org/chromium/chromium/src/+/4277cccd0ac1324d9a2e60ba788e9a6992231309 commit 4277cccd0ac1324d9a2e60ba788e9a6992231309 Author: Tom Anderson <[email protected]> Date: Tue Aug 29 00:44:16 2023 +0000 Remove prefs::kUsesSystemThemeDeprecated Change-Id: I4dd88a0ff0ad866518343a15bde1300fa7b4d6c5

This change adds the `chromium_photos` provider to the list of providers linked in the iOS build, as it is now required to get the full binary linked. Chromium change: https://chromium.googlesource.com/chromium/src/+/4315ac78ee76f8ca48ecfaaedd889d74b26abeaf commit 4315ac78ee76f8ca48ecfaaedd889d74b26abeaf Author: Quentin Pubert <[email protected]> Date: Wed Aug 9 15:21:01 2023 +0000 [iOS] Add Photos Library provider for Save to Photos - ios/chrome/browser/providers/BUILD.gn - ios/chrome/browser/providers/photos/BUILD.gn - ios/chrome/browser/providers/photos/chromium_photos.mm - ios/chrome/browser/providers/photos/DEPS The Chromium provider returns an UnavailablePhotosService which is always unavailable. - ios/chrome/test/providers/BUILD.gn - ios/chrome/test/providers/photos/BUILD.gn - ios/chrome/test/providers/photos/test_photos.mm The test provider returns a fake. - ios/public/provider/chrome/browser/BUILD.gn - ios/public/provider/chrome/browser/photos/BUILD.gn - ios/public/provider/chrome/browser/photos/photos_api.h The provider API contains on function ``` std::unique_ptr<PhotosService> CreatePhotosService( PhotosServiceConfiguration* configuration) ``` which returns the service implementation for a given `configuration`. Low-Coverage-Reason: Chromium providers cannot be tested in the same CL Bug: 1471386

Chromium change: https://chromium.googlesource.com/chromium/src/+/32fa34e78d03562cecc694c0236a9953195ea3d7 commit 32fa34e78d03562cecc694c0236a9953195ea3d7 Author: Justin Novosad <[email protected]> Date: Wed Aug 30 22:25:16 2023 +0000 Move more text rendering code into BaseRenderingContext2D This is a code cleanup and refactor that will make it easier to implement text rendering functionality in canvas display lists Bug: 1467562

Upstream has changed the access to the members of handle objects in V8 to be accessed with an arrow. Chromium change: https://chromium.googlesource.com/v8/v8/+/95532da70de14206e64060647082766a293f81cb commit 95532da70de14206e64060647082766a293f81cb Author: Leszek Swirski <[email protected]> Date: Fri Jul 21 12:10:15 2023 +0200 [tagged-ptr] Arrowify objects Change obj.foo() into obj->foo() for subtypes of Objects, excluding operations that work directly on the this pointer value (practically, anything in Object/Smi themselves, and a few functions in HeapObject). This is a mostly automatic change, with the following clang matcher: traverse(clang::TK_IgnoreUnlessSpelledInSource, cxxMemberCallExpr( callee( memberExpr( unless(anyOf( isArrow(), hasDeclaration( cxxMethodDecl( ofClass(cxxRecordDecl(anyOf( hasName("v8::internal::TaggedImpl"), hasName("v8::internal::Object") ))) ) ), allOf( anyOf( member(hasName("is_null")), member(hasName("address")), member(matchesName("Is.*")), member(matchesName("In.*")) ), hasDeclaration( cxxMethodDecl( ofClass(cxxRecordDecl( hasName("v8::internal::HeapObject") )) ) ) ) )) ).bind("member") ), thisPointerType(cxxRecordDecl( anyOf( isSameOrDerivedFrom(hasName("v8::internal::HeapObject")), hasName("v8::internal::Object") ) )) ) ) Bug: v8:12710

Upstream has changed `ContentAutofillDriver` to expose `AutofillManager` as a reference, in a virtual function. Some of our browser tests had to be corrected for this type of access. Chromium change: https://chromium.googlesource.com/chromium/src/+/3edeee8d9b94744a24974940a604a79c0a84bd3d commit 3edeee8d9b94744a24974940a604a79c0a84bd3d Author: Christoph Schwering <[email protected]> Date: Tue Sep 5 12:44:37 2023 +0000 [Autofill] Introduce AutofillDriver::GetAutofillManager() This CL replaces {ContentAutofillDriver,AutofillDriverIOS}::autofill_manager() with a function in the interface AutofillDriver::GetAutofillManager(). This is needed for crrev.com/c/4833636. It also changes its return type from pointer to reference. crbug.com/1478762. Bug: 1007974

This substitution of `WrapUnique` possibly shouldn't exist in the first place. This change is preempting a breakage in mojo headers, where this replacement was causing issues.

This particular test was relying on transient inclusions for its inclusion of StringPiece.

Chromium change: https://source.chromium.org/chromium/chromium/src/+/26ad5e4fe1eb750eb98aa3cf5b2bc91c6edf9a2b commit 26ad5e4fe1eb750eb98aa3cf5b2bc91c6edf9a2b Author: Shubham Gupta <[email protected]> Date: Thu Aug 31 04:34:23 2023 +0000 Remove expired histograms This CL removes the following expired histograms: - Platform.LogicalCpuCount - Windows.IsPinnedToTaskbar.ProcessError Bug: 1448106

Chromium change: brave/chromium@3a647ee [SBv5] Replace setHandler with setSafetyNetApiHandler In https://crrev.com/c/4702473, we left a TODO to replace setHandler with setSafetyNetApiHandler and remove setHandler. The internal usage was removed in https://crrev.com/i/6342787 This CL is to replace the usage in the external repo. Bug: 1444511

Chromium change: brave/chromium@ba278ec Dropdown Builder: Introduce support for horizontal render groups. This change enables DropdownItemViewInfoListBuilder to create Horizontal Render groups. Horizontal render groups are constructed with the help of a single PropertyModel, that is internally turned into a desired view hierarchy by the appropriate component. A single PropertyModel is created for the entire group, and amended with every next suggestion that belongs to the same group. Bug: 1474087

Chromium change: brave/chromium@698cb6c [APS] Trigger zero-prefix dropdown on tapping the omnibox after it is auto-focused Opening the NTP automatically focuses on the omnibox with a blinking cursor and without triggering the zero-prefix dropdown when a physical keyboard is connected to a tablet device. This CL adds support to show the zero-prefix dropdown when the omnibox is tapped at this point. This CL also renames/repurposes AutocompleteMediator#onUrlFocusChange() to report metrics and activate/deactivate the autocomplete session as follows: 1. The autocomplete session will not be activated when the omnibox is initially focused. This will be done only if the user taps on / types into the omnibox after such focus. 2. If the user chooses not to interact with the omnibox after such focus, the autocomplete session deactivation logic in this method will not be executed. Bug: 1445822

Chromium change: https://source.chromium.org/chromium/chromium/src/+/e83ad48b7de16798e682a50ab68f5fcb3f09b3f9 commit e83ad48b7de16798e682a50ab68f5fcb3f09b3f9 Author: sbingler <[email protected]> Date: Mon Aug 28 18:57:04 2023 +0000 Allow partitioned storage by default when 3p cookies are disabled Blocking third-party cookies by default (ex: through the toggle in a new incognito tab) currently disabled all third-party storage as well. This CL allows access to partitioned storage when third-party cookies are disabled by default. This only applies when third-party cookies are disabled by default across all urls. If cookies are disabled through a user specified rule/pattern then storage will continue to be disabled as well. Bug: 1453783

Chromium change: brave/chromium@6561d5a [APS] Support keyboard shortcut to display omnibox search result in new tab When a search query is entered into the omnibox while a hardware keyboard is connected, hitting ALT + ENTER should load the search result in a new tab. Phone: https://drive.google.com/file/d/1oGRfLDZx9zlLSLVMN28UmdZsPhXkGK7Y/view?usp=sharing Tablet: https://drive.google.com/file/d/1jQfSk_3m9fiowvMFckhlIyB56ZdBWtkp/view?usp=sharing Bug: 1451922

Chromium change: https://source.chromium.org/chromium/chromium/src/+/b2f557c563e440329f23c971faa85a9db0b41a14 commit b2f557c563e440329f23c971faa85a9db0b41a14 Author: Thomas Lukaszewicz <[email protected]> Date: Tue Sep 12 14:38:24 2023 +0000 [M118 Merge][color] Refactor AccentColorObserver to store accent color Currently AccentColorObserver stores the windows system accent color only if ColorPrevalence == 1. This CL refactors the accent observer slightly to store the system defined accent color if it has been set, and store whether the accent color should be used for the dwm frame colors separately. This is in service of integrating windows accent colors into the new Panorama theme selector. (cherry picked from commit a37bda5c6c23021ddd4eddb5b142b07a8c1f6a14) Bug: 1469713, 1477908

Chromium change: brave/chromium@bc4d3e8 [APS] Add tooltip text and circular highlight for StatusView Demo: https://drive.google.com/file/d/19ZWK0emmShyTWOjdl52mvHrtz-6U1zxT/view?usp=sharing Additional demo to verify long-click: https://drive.google.com/file/d/1AVdyEHtcRnJkVkexk8fjgN7Rmb6dklAF/view?usp=sharing Bug: 1473109

Chromium change: https://source.chromium.org/chromium/chromium/src/+/ab4fe6fcbc5ce41903484af7568a159fda50ec33 commit ab4fe6fcbc5ce41903484af7568a159fda50ec33 Author: Joshua Pawlicki <[email protected]> Date: Fri Sep 8 19:04:35 2023 +0000 UMA: Provide update cohort ID in UMA upload. This enables ITT analyses of Chrome Windows. (cherry picked from commit 96b6136b66ead81d43a31dbe729a198b6ddf0967) Low-Coverage-Reason: Testing the metrics provider itself is not useful. Fixed: 1473054

Chromium change: brave/chromium@795632a Strip GestureDetector. The change removes GestureDetector used to differentiate between Omnibox taps and long-presses. Long-press gesture has lost all its meaning back when we introduced Search Ready Omnibox and Clipboard support: the omnibox comes up empty (meaning the user cannot use the gesture to select all its content), and cannot use this gesture to directly paste into the omnibox (it's never been directly supported; we have dedicated actions for that). As such, the long-press on the Omnibox does nothing else than focus the Omnibox. The change simplifies metrics reporting and obsoletes the OmniboxFocusReason.OmniboxLongClick action. The change further simplifies the focus flow by removing "set and reset omnibox text": upon Focus event, LocationBarMediator no longer sets the Omnibox text content (which next had to be cleared by the EditUrlSuggestionProcessor). Instead, the LocationBarMediator supplies an empty input right from the start. This works the same way the current logic does, skipping one extra content setting, and simplifying some of the Omnibox interfaces. Change-Id: I067d538c2c0f424603ed520f6d9fbd06c5f5da6f

…derChip Chromium change: https://source.chromium.org/chromium/chromium/src/+/d5ce2ff0aa7c0d44514a37330b7c722b9f9d7222 commit d5ce2ff0aa7c0d44514a37330b7c722b9f9d7222 Author: Shibalik Mohapatra <[email protected]> Date: Thu Aug 31 16:59:41 2023 +0000 [SavedTabGroup] Add correct padding in tab group header with sync icon. Change-Id: I42111a67c8fe404486af978a6b82ece946f16c57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade from Chromium 117 to Chromium 118 #19765

Upgrade from Chromium 117 to Chromium 118 #19765

Commits on Sep 27, 2023