Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 117 to Chromium 118 #19765

Merged
merged 76 commits into from
Sep 27, 2023
Merged

Upgrade from Chromium 117 to Chromium 118 #19765

merged 76 commits into from
Sep 27, 2023

Conversation

cdesouza-chromium
Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium commented Aug 18, 2023 •
edited by emerick
Loading

Resolves brave/brave-browser#32933

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) feature/web3/wallet feature/web3/wallet/core labels Aug 18, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

cdesouza-chromium and others added 17 commits September 27, 2023 13:08
@cdesouza-chromium
Preempt substitutions in ChromeAutofillClient
bdb1a34 
This substitution of `WrapUnique` possibly shouldn't exist in the first
place. This change is preempting a breakage in mojo headers, where this
replacement was causing issues.
@cdesouza-chromium
IWYU StringPiece fixes
b25c2c1 
This particular test was relying on transient inclusions for its
inclusion of StringPiece.
@emerick @cdesouza-chromium
GetIsPinnedToTaskbarState no longer takes error callback parameter
bbd1fb6 
Chromium change:

https://source.chromium.org/chromium/chromium/src/+/26ad5e4fe1eb750eb98aa3cf5b2bc91c6edf9a2b

commit 26ad5e4fe1eb750eb98aa3cf5b2bc91c6edf9a2b
Author: Shubham Gupta <[email protected]>
Date:   Thu Aug 31 04:34:23 2023 +0000

    Remove expired histograms

    This CL removes the following expired histograms:
    - Platform.LogicalCpuCount
    - Windows.IsPinnedToTaskbar.ProcessError

    Bug: 1448106
@emerick @cdesouza-chromium
Adjust resource_ids.spec to avoid duplicate resources with upstream
c4af807
@samartnik @cdesouza-chromium
[Android] Replace setHandler with setSafetyNetApiHandler
1b587ae 
Chromium change:
brave/chromium@3a647ee

[SBv5] Replace setHandler with setSafetyNetApiHandler
In https://crrev.com/c/4702473, we left a TODO to replace setHandler
with setSafetyNetApiHandler and remove setHandler.

The internal usage was removed in https://crrev.com/i/6342787

This CL is to replace the usage in the external repo.

Bug: 1444511
@samartnik @cdesouza-chromium
[Android] Changes for omnibox suggestions
474f871 
Chromium change:
brave/chromium@ba278ec

Dropdown Builder: Introduce support for horizontal render groups.
This change enables DropdownItemViewInfoListBuilder to create
Horizontal Render groups.

Horizontal render groups are constructed with the help of a single
PropertyModel, that is internally turned into a desired view hierarchy
by the appropriate component.

A single PropertyModel is created for the entire group, and amended
with every next suggestion that belongs to the same group.

Bug: 1474087
@samartnik @cdesouza-chromium
[Android] Rename onUrlFocusChange to onOmniboxSessionStateChange
60217f5 
Chromium change:
brave/chromium@698cb6c

[APS] Trigger zero-prefix dropdown on tapping the omnibox after it is
auto-focused

Opening the NTP automatically focuses on the omnibox with a blinking
cursor and without triggering the zero-prefix dropdown when a physical
keyboard is connected to a tablet device.

This CL adds support to show the zero-prefix dropdown when the omnibox
is tapped at this point.

This CL also renames/repurposes AutocompleteMediator#onUrlFocusChange() to report metrics and activate/deactivate the autocomplete session as follows:
1. The autocomplete session will not be activated when the omnibox is initially focused. This will be done only if the user taps on / types into the omnibox after such focus.
2. If the user chooses not to interact with the omnibox after such focus, the autocomplete session deactivation logic in this method will not be executed.

Bug: 1445822
@emerick @cdesouza-chromium
Disable net::features::kThirdPartyPartitionedStorageAllowedByDefault
d284f96 
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/e83ad48b7de16798e682a50ab68f5fcb3f09b3f9

commit e83ad48b7de16798e682a50ab68f5fcb3f09b3f9
Author: sbingler <[email protected]>
Date:   Mon Aug 28 18:57:04 2023 +0000

    Allow partitioned storage by default when 3p cookies are disabled

    Blocking third-party cookies by default (ex: through the toggle in a new
    incognito tab) currently disabled all third-party storage as well.

    This CL allows access to partitioned storage when third-party cookies
    are disabled by default.

    This only applies when third-party cookies are disabled by default
    across all urls. If cookies are disabled through a user specified rule/pattern then storage will continue to be disabled as well.

    Bug: 1453783
@samartnik @cdesouza-chromium
[Android] New signature for loadUrlForOmniboxMatch
5f57f88 
Chromium change:
brave/chromium@6561d5a

[APS] Support keyboard shortcut to display omnibox search result in new
tab

When a search query is entered into the omnibox while a hardware
keyboard is connected, hitting ALT + ENTER should load the search result
in a new tab.

Phone:
https://drive.google.com/file/d/1oGRfLDZx9zlLSLVMN28UmdZsPhXkGK7Y/view?usp=sharing
Tablet:
https://drive.google.com/file/d/1jQfSk_3m9fiowvMFckhlIyB56ZdBWtkp/view?usp=sharing

Bug: 1451922
@emerick @cdesouza-chromium
Add use_dwm_frame_color() to FakeAccentColorObserver
c07c034 
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/b2f557c563e440329f23c971faa85a9db0b41a14

commit b2f557c563e440329f23c971faa85a9db0b41a14
Author: Thomas Lukaszewicz <[email protected]>
Date:   Tue Sep 12 14:38:24 2023 +0000

    [M118 Merge][color] Refactor AccentColorObserver to store accent color

    Currently AccentColorObserver stores the windows system accent color
    only if ColorPrevalence == 1.

    This CL refactors the accent observer slightly to store the system
    defined accent color if it has been set, and store whether the
    accent color should be used for the dwm frame colors separately.

    This is in service of integrating windows accent colors into the new
    Panorama theme selector.

    (cherry picked from commit a37bda5c6c23021ddd4eddb5b142b07a8c1f6a14)

    Bug: 1469713, 1477908
@samartnik @cdesouza-chromium
[Android] Fixes for unit tests
d344fe7
@emerick @cdesouza-chromium
Disable features flagged by privacy/security team
b5e94a7
@samartnik @cdesouza-chromium
[Android] Fix for the status view icon
a013297 
Chromium change:
brave/chromium@bc4d3e8

[APS] Add tooltip text and circular highlight for StatusView
Demo: https://drive.google.com/file/d/19ZWK0emmShyTWOjdl52mvHrtz-6U1zxT/view?usp=sharing
Additional demo to verify long-click: https://drive.google.com/file/d/1AVdyEHtcRnJkVkexk8fjgN7Rmb6dklAF/view?usp=sharing

Bug: 1473109
@emerick @cdesouza-chromium
Override USE_GOOGLE_UPDATE_INTEGRATION macro
9808a30 
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/ab4fe6fcbc5ce41903484af7568a159fda50ec33

commit ab4fe6fcbc5ce41903484af7568a159fda50ec33
Author: Joshua Pawlicki <[email protected]>
Date:   Fri Sep 8 19:04:35 2023 +0000

    UMA: Provide update cohort ID in UMA upload.

    This enables ITT analyses of Chrome Windows.

    (cherry picked from commit 96b6136b66ead81d43a31dbe729a198b6ddf0967)

    Low-Coverage-Reason: Testing the metrics provider itself is not useful.
    Fixed: 1473054
@samartnik @cdesouza-chromium
[Android] Changes for omibox focus behaviour
5588d54 
Chromium change:
brave/chromium@795632a

Strip GestureDetector.
The change removes GestureDetector used to differentiate between
Omnibox taps and long-presses.

Long-press gesture has lost all its meaning back when we introduced
Search Ready Omnibox and Clipboard support: the omnibox comes up empty
(meaning the user cannot use the gesture to select all its content),
and cannot use this gesture to directly paste into the omnibox (it's
never been directly supported; we have dedicated actions for that).

As such, the long-press on the Omnibox does nothing else than focus
the Omnibox.

The change simplifies metrics reporting and obsoletes the
OmniboxFocusReason.OmniboxLongClick action.

The change further simplifies the focus flow by removing "set and
reset omnibox text": upon Focus event, LocationBarMediator no longer
sets the Omnibox text content (which next had to be cleared by the
EditUrlSuggestionProcessor). Instead, the LocationBarMediator supplies
an empty input right from the start. This works the same way the
current logic does, skipping one extra content setting, and
simplifying some of the Omnibox interfaces.

Change-Id: I067d538c2c0f424603ed520f6d9fbd06c5f5da6f
@samartnik @cdesouza-chromium
[Android] Fixes for the presubmit errors
1b6a16f
@emerick @cdesouza-chromium
Add should_show_sync_icon parameter to TabGroupStyle::GetInsetsForHea…
438a3eb 
…derChip

Chromium change:
https://source.chromium.org/chromium/chromium/src/+/d5ce2ff0aa7c0d44514a37330b7c722b9f9d7222

commit d5ce2ff0aa7c0d44514a37330b7c722b9f9d7222
Author: Shibalik Mohapatra <[email protected]>
Date:   Thu Aug 31 16:59:41 2023 +0000

    [SavedTabGroup] Add correct padding in tab group header with sync icon.

    Change-Id: I42111a67c8fe404486af978a6b82ece946f16c57
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

iefremov
iefremov approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@iefremov iefremov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just did a quick check of what's looking relevant to me, haven't had enough time to review because of PTO

@emerick emerick merged commit 4220271 into master Sep 27, 2023
15 checks passed
@emerick emerick deleted the cr118 branch September 27, 2023 15:50
@emerick emerick added this to the 1.60.x - Nightly milestone Sep 27, 2023
@emerick emerick mentioned this pull request Sep 28, 2023
Merged
25 tasks
emerick added a commit that referenced this pull request Sep 28, 2023
@emerick
Merge pull request #19765 from brave/cr118
e564b9c 
Upgrade from Chromium 117 to Chromium 118
kjozwiak pushed a commit that referenced this pull request Oct 2, 2023
@emerick
Upgrade from Chromium 117 to Chromium 118 (1.59.x) (#20326)
5956f81 
Merge pull request #19765 from brave/cr118

Upgrade from Chromium 117 to Chromium 118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick left review comments

@goodov goodov goodov approved these changes

@bridiver bridiver bridiver approved these changes

@rillian rillian rillian approved these changes

@kylehickinson kylehickinson kylehickinson approved these changes

@tmancey tmancey tmancey approved these changes

@iefremov iefremov iefremov approved these changes

@bsclifton bsclifton bsclifton approved these changes

@zenparsing zenparsing zenparsing approved these changes

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

@AlexeyBarabash AlexeyBarabash AlexeyBarabash approved these changes

@mkarolin mkarolin mkarolin approved these changes

Assignees

@emerick emerick

@samartnik samartnik

@cdesouza-chromium cdesouza-chromium

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.60.x - Release
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 117 to Chromium 118