Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all NANs when genes with all zeros. #11 #12

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zqfang
Copy link

@zqfang zqfang commented Dec 29, 2018

I have the same issue that " DataFrame contains rows which are entirely zero the result returned by combat() will contain all NaNs".
May be it's a good choice to drop these entirely zeros, because all zeros could no be corrected further.
Hope this is usefull

@brentp
Copy link
Owner

brentp commented Dec 29, 2018

I think you'd need something like:

(data != 0).sum(axis=1) > 0

but since I haven't been looking at/using this code for some time, I'd require a test before merging this.

@rvinas
Copy link

rvinas commented Mar 8, 2019

How does the original script handle constant-valued genes? I don't think it's a good practice to remove them within the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants