Improve @WebParam class loading in JsonRpcBasicServer #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javax.jws.WebParam class is part of JDK in Java 1.8, and it is always present. If Jakarta variant is present in classpath, then needs to be loaded first, otherwise it will be overridden with javax.jws.WebParam from JDK 1.8 The drawback is that it changes previous behavior and expectations. If jakarta.jws.WebParam is in classpath, then methods annotated with javax.jws.WebParam may no longer work. Signed-off-by: cyb3r4nt <[email protected]>
…e time Previous class loading solution assumed that there is only one @WebParam class. Both of these annotation classes may be used in some applications. This current change tries to load both classes if these are available from classpath. Then both classes are used in detection of method parameters. Signed-off-by: cyb3r4nt <[email protected]>
cyb3r4nt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve @WebParam class loading in JsonRpcBasicServer
javax.jws.WebParamclass is part of JDK in Java 1.8, and it is always present.If Jakarta variant is also present in classpath, then needs to be loaded first,
otherwise it will be overridden by
javax.jws.WebParamfrom JDK 1.8.Tests are successful when JDK 11+ is used, because
javax.jws.WebParamis no longer present by default,and proper class is loaded.
There may be applications where both
javax.jws.WebParamandjakarta.jws.WebParamare present.This new implementation tries to load both classes and use them in the detection of method parameters.
This means that older code, which uses
javax.jws.WebParam, should be fine even if application has newer dependency versions, wherejakarta.jws.WebParamis also included.When JDK 11+ is used and there are
jakarta.jws.WebParamannotated parameters present in the application,then a jar containing
javax.jws.WebParamclass should be explicitly included into classpath.This probably fixes problems in issue #310
Test issues in #310 can be reproduced with JDK 1.8.