Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve @WebParam class loading in JsonRpcBasicServer #314

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve @WebParam class loading in JsonRpcBasicServer #314

wants to merge 2 commits into from

Commits on Jun 13, 2023

  1. Reorder @WebParam class loading in JsonRpcBasicServer 

    javax.jws.WebParam class is part of JDK in Java 1.8, and it is always present.
If Jakarta variant is present in classpath,
then needs to be loaded first,
otherwise it will be overridden with javax.jws.WebParam from JDK 1.8

The drawback is that it changes previous behavior and expectations.
If jakarta.jws.WebParam is in classpath,
then methods annotated with javax.jws.WebParam may no longer work.


Signed-off-by: cyb3r4nt <[email protected]>
    @cyb3r4nt
    cyb3r4nt committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    4b32e36 View commit details
    Browse the repository at this point in the history

  2. Make both javax.jws.WebParam and jakarta.jws.WebParam work at the sam… 

    …e time

Previous class loading solution assumed that there is only one @WebParam class.
Both of these annotation classes may be used in some applications.

This current change tries to load both classes if these are available from classpath.
Then both classes are used in detection of method parameters.


Signed-off-by: cyb3r4nt <[email protected]>
    @cyb3r4nt
    cyb3r4nt committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    b0c7605 View commit details
    Browse the repository at this point in the history