Don't crash with ZeroDivisionError if initial test ELBO is the best test ELBO #312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --final-elbo-fail-fraction test checks that the final test ELBO isn't much worse than the best test ELBO. It checks the (distance between final test ELBO and best test ELBO)/(distance between initial test ELBO and best test ELBO).
This causes a ZeroDivisionError if best test ELBO == initial test ELBO.
Solution:
If --final-elbo-fail-fraction is enabled && final test ELBO < best test ELBO && initial test ELBO == best test ELBO
then training is considered to have failed.