Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix major bug in v0.3.1: negative counts #347

Merged
merged 17 commits into from
Apr 11, 2024
Merged

Fix major bug in v0.3.1: negative counts #347

merged 17 commits into from
Apr 11, 2024

Commits on Apr 5, 2024

  1. Update gitignore

    @sjfleming
    sjfleming committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    417cd5a View commit details
    Browse the repository at this point in the history

  2. Github actions run on master and dev PRs only

    @sjfleming
    sjfleming committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    228d434 View commit details
    Browse the repository at this point in the history

  3. issue #348 lxml_html_clean dependency

    @sjfleming
    sjfleming committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    d68c515 View commit details
    Browse the repository at this point in the history

  4. Fix #306: noise count integer overflow

    @sjfleming
    sjfleming committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    b73fd56 View commit details
    Browse the repository at this point in the history

  5. Make dtypes more explicit

    @sjfleming
    sjfleming committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    4bdc4f4 View commit details
    Browse the repository at this point in the history

  6. Unit test that fails before fix

    @sjfleming
    sjfleming committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    dc8daad View commit details
    Browse the repository at this point in the history

  7. integration test for negative outputs: also fails before fix

    @sjfleming
    sjfleming committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    4ee2350 View commit details
    Browse the repository at this point in the history

  8. Conversion to torch was a problem from uints

    @sjfleming
    sjfleming committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    95f0136 View commit details
    Browse the repository at this point in the history

  9. Correct a test that was unfairly failing when gene dtype was int32

    @sjfleming
    sjfleming committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    1cb8479 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. More informative print statement in test

    @sjfleming
    sjfleming committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    2b11727 View commit details
    Browse the repository at this point in the history

  2. Failsafe to ensure no negative entries in output

    @sjfleming
    sjfleming committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    411cc39 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Introduce --force-use-checkpoint for redoing v0.3.1 runs

    @sjfleming
    sjfleming committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    1fd390f View commit details
    Browse the repository at this point in the history

  2. Add a warning to the README about v0.3.1

    @sjfleming
    sjfleming committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    2ba1b93 View commit details
    Browse the repository at this point in the history

  3. rst warning does not render in github readme

    @sjfleming
    sjfleming committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    e04f30b View commit details
    Browse the repository at this point in the history

  4. Another attempt at rst rendering

    @sjfleming
    sjfleming committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    00901cb View commit details
    Browse the repository at this point in the history

  5. Add the word "warning"

    @sjfleming
    sjfleming committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    49a3e3e View commit details
    Browse the repository at this point in the history

  6. Fix test failure introduced by --force-use-checkpoint

    @sjfleming
    sjfleming committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    2548446 View commit details
    Browse the repository at this point in the history