Skip to content

Kl/qc meta #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 56 commits into
base: main
Choose a base branch
from
Open

Kl/qc meta #723

wants to merge 56 commits into from

Conversation

@klaricch
Copy link
Contributor

@klaricch klaricch commented Oct 17, 2025

No description provided.

@klaricch klaricch requested a review from a team as a code owner October 17, 2025 19:10
mike-w-wilson
mike-w-wilson requested changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@mike-w-wilson mike-w-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know there are a lot of comments but half are around workflow and just doc edits. @ch-kr said she would take this over after the first pass when I'm out.

@mike-w-wilson mike-w-wilson requested a review from ch-kr October 21, 2025 18:49
@klaricch klaricch requested a review from Copilot October 31, 2025 14:40
Copilot AI reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

gnomad_qc/v5/sample_qc/create_sample_qc_metadata_ht.py Outdated
"""
Get relatedness filtering Table for the combined meta Table.
Add the following related filter boolean annotations to the input `ht` under a
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra whitespace before 'Add' creates inconsistent indentation in the docstring. The description should start at the same indentation level as the previous line.

Suggested change
Add the following related filter boolean annotations to the input `ht` under a
Add the following related filter boolean annotations to the input `ht` under a

Copilot uses AI. Check for mistakes.
@klaricch klaricch requested a review from Copilot November 4, 2025 18:27
Copilot AI reviewed Nov 4, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ch-kr
ch-kr reviewed Nov 5, 2025
View reviewed changes
Copy link
Contributor

@ch-kr ch-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor docstring suggestions and one question

ch-kr
ch-kr approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@ch-kr ch-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating review since I answered my own question and the other suggestions are minor

mike-w-wilson
mike-w-wilson approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@mike-w-wilson mike-w-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny thing then looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mike-w-wilson mike-w-wilson mike-w-wilson approved these changes

@ch-kr ch-kr ch-kr approved these changes

Assignees

@klaricch klaricch

@mike-w-wilson mike-w-wilson

@ch-kr ch-kr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@klaricch @mike-w-wilson @ch-kr