Fix for resolving dg.712C vs dg.712c BT-24 (#199)

broadinstitute · Nov 9, 2020 · 8e3fc7e · 8e3fc7e
1 parent c9030a9
commit 8e3fc7e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/martha/martha_v3.js b/martha/martha_v3.js
@@ -200,7 +200,8 @@ function getHttpsUrlParts(url) {
                 ),
             httpsUrlSearch: cibMatch.groups.query,
             // See `determineDrsType` for more info on this `martha_v2` backwards compatibility
-            httpsUrlMaybeNotBdc: ![DG_COMPACT_BDC_PROD, DG_COMPACT_BDC_STAGING].includes(cibMatch.groups.host),
+            httpsUrlMaybeNotBdc:
+                ![DG_COMPACT_BDC_PROD, DG_COMPACT_BDC_STAGING].includes(cibMatch.groups.host.toLowerCase()),
         };
     }
 

diff --git a/test/martha/martha_v3.test.js b/test/martha/martha_v3.test.js
@@ -504,7 +504,7 @@ test.serial('martha_v3 parses BDC staging response correctly', async (t) => {
     getJsonFromApiStub.onFirstCall().resolves(bdcDrsResponse);
     const response = mockResponse();
     await marthaV3(
-        mockRequest({ body: { 'url': 'drs://dg.712c/fc046e84-6cf9-43a3-99cc-ffa2964b88cb' } }),
+        mockRequest({ body: { 'url': 'drs://dg.712C/fc046e84-6cf9-43a3-99cc-ffa2964b88cb' } }),
         response,
     );
     const result = response.send.lastCall.args[0];
@@ -514,7 +514,7 @@ test.serial('martha_v3 parses BDC staging response correctly', async (t) => {
     t.is(
         getJsonFromApiStub.firstCall.args[0],
         'https://staging.gen3.biodatacatalyst.nhlbi.nih.gov/ga4gh/dos/v1/dataobjects' +
-        '/dg.712c/fc046e84-6cf9-43a3-99cc-ffa2964b88cb',
+        '/dg.712C/fc046e84-6cf9-43a3-99cc-ffa2964b88cb',
     );
     t.falsy(getJsonFromApiStub.firstCall.args[1]); // no auth passed
     const requestedBondUrl = getJsonFromApiStub.secondCall.args[0];