Add hail backend - intitial status check #3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShifaSZ
reviewed
Jul 12, 2023
| app = init_web_app() | ||
| web.run_app( | ||
| app, | ||
| host='0.0.0.0', # nosec |
There was a problem hiding this comment.
It looks like a backend service web app without authentication support. It should not be accessible from external.
There was a problem hiding this comment.
Correct. The hail backend service will only be accessible via an internal, unauthenticated kubernetes service, so that only seqr can access it. Actually setting up the deployment is out of scope of this PR, but you can see the kubernetes yaml that I used to get this working in a test environment here: https://github.com/broadinstitute/seqr/blob/62084009dd60a35eef1c85608ad0c8a3e2a90cf8/deploy/kubectl_helpers/utils/hail-search.yaml
ShifaSZ
approved these changes
Jul 12, 2023
sjahl
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the directory and basic scaffolding for adding the hail search app to seqr. Currently, all this adds is a status endpoint and unit tests. The hail search app uses aiohttp, as this library comes built in on the hail docker image we are using, and is therefore the most lightweight and best supported approach.
Future work will be needed to actually release docker images for the hail search backend, but I wanted to wait until there was a bit more functionality integrated in before adding that