Add a link to the SpliceAI lookup page on the SpliceAI predictions #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example UI |
hanars
requested changes
Jul 13, 2023
| @@ -69,7 +71,11 @@ const Prediction = ({ field, fieldTitle, value, color, infoValue, infoTitle, war | |||
| <div> | |||
| {indicator} | |||
| {fieldDisplay} | |||
| <PredictionValue>{value}</PredictionValue> | |||
| {href ? ( | |||
| <ButtonLink as="a" href={href} target="_blank" rel="noreferrer"> | |||
There was a problem hiding this comment.
<ButtonLink as="a" is just a more complicated way to write <a. There is no advantage to making this a button as it needs no onclick behavior, so it should just be a link
| @@ -13,7 +13,7 @@ import { ButtonLink } from '../../StyledComponents' | |||
| const PredictionValue = styled.span` | |||
| margin-left: 5px; | |||
| font-weight: bolder; | |||
| color: black; | |||
| color: ${props => props.color}; | |||
| text-transform: uppercase; | |||
There was a problem hiding this comment.
so this should not be an explicit prop, using an actual link for the value should fix the style issue
| <ButtonLink as="a" href={href} target="_blank" rel="noreferrer"> | ||
| <PredictionValue>{value}</PredictionValue> | ||
| </ButtonLink> | ||
| ) : <PredictionValue color="black">{value}</PredictionValue>} |
There was a problem hiding this comment.
it is cleaner to wrap the value in the link if needed, instead of rendering PredictionValue twice:
const valueDisplay = href ? <a href={href} target="_blank" rel="noreferrer">{value}</a> : value
...
<PredictionValue>{valueDisplay}</PredictionValue>
hanars
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the connected issue.