Break the RNASeq links into new lines #3511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanars
requested changes
Jul 26, 2023
| <Link to={`/project/${individual.projectGuid}/family_page/${individual.familyGuid}/matchmaker_exchange`}> | ||
| <Link | ||
| to={`/project/${individual.projectGuid}/family_page/${individual.familyGuid}/matchmaker_exchange`} | ||
| style={BREAK_LINE_STYLING} |
There was a problem hiding this comment.
we do not use the style prop, we use styled components, unless there is an overwhelming compelling reason to do otherwise
| const MmeStatusLabel = React.memo(({ title, dateField, color, individual, mmeSubmission }) => ( | ||
| <Link to={`/project/${individual.projectGuid}/family_page/${individual.familyGuid}/matchmaker_exchange`}> | ||
| <Link |
There was a problem hiding this comment.
why not just wrap it in a div?
hanars
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break the ExchangeMatching and the RNAseq links into different lines, and keep the spacing consistent.
Before:
After:
