Hail backend filter location #3528
Conversation
…oadinstitute/seqr into hail-backend-filter-location
…oadinstitute/seqr into hail-backend-filter-location
hail_search/hail_search_query.py
Outdated
| @property | ||
| def should_add_chr_prefix(self): | ||
| reference_genome = hl.get_reference(self._genome_version) | ||
| return any(c.startswith('chr') for c in reference_genome.contigs) |
There was a problem hiding this comment.
Using an attribute of the class and initializing it in the __init__ function performs better.
There was a problem hiding this comment.
no @property performs better because it will only be initialized if it is actually used which this isn't in lots of searches, but once its initialized the value is reused on every subsequent call and its not recomputed
There was a problem hiding this comment.
Would you mind giving more context on why @property saves the recomputation? We might need @functools.cached_property to get the caching behavior (and I think exactly the behavior Shifa was asking for plus the benefit of it only being initialized if it's actually used).
There was a problem hiding this comment.
oh I think I misunderstood what the property was doing. I'll look into this
There was a problem hiding this comment.
The property needs recomputation when self._genome_version is changed.
…oadinstitute/seqr into hail-backend-filter-location
No description provided.