add clinvar pathogenicity to ui constants #3978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanars
approved these changes
Mar 18, 2024
hanars
requested changes
Mar 18, 2024
There was a problem hiding this comment.
Actually this change is not as urgent as we thought, CLINVAR_PATHOGENICITIES is referenced inside an if (clinicalSignificance && !pathogenicity) block, which captures cases from the ES v2 pipeline, and this new pathogenicity will only be coming from the v3 pipeline, so there will be no bug in terms of displaying it as the main pathogenicity value. However, it will not be properly color coded as red in the UI, so its still worth merging this
hanars
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corresponds to pipeline change in this PR