Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gene_known_for_phenotype from tags #3982

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Conversation

hanars
Copy link
Collaborator

@hanars hanars commented Mar 19, 2024

No description provided.

Copy link
Contributor

@jklugherz jklugherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was the improvement here? it looks like the logic for assigning the gene_known_for_phenotype tag is almost same, just in a different spot, but I know there's something else in here

@hanars
Copy link
Collaborator Author

hanars commented Mar 19, 2024

The logic has changed, its now determined based on variant tags instead of by the family omim_number/ mondo_id. It was being set as

Case(When(
            Q(family__post_discovery_omim_numbers__len=0, family__mondo_id__isnull=True),
            then=Value('Candidate')), default=Value('Known')
        )

and is now being set as 'Known' if 'Known gene for phenotype' in variant.tags else 'Candidate',

@hanars hanars merged commit dd795a3 into dev Mar 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants