[CI] Prevent dependencies from floating when linking core repo #1129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we do
bundle lock --update ...
that allows various dependencies to float up to a new version if one has been released. This prevents that from happening.For instance in
bullet_train-api
we specify a dependency onjbuilder-schema
of>= 2.4.0
. InGemfile.lock
of the starter repo we had it set to2.5.0
. But when2.6.0
was released we started to see failured in CI due to a bug. Since the version was just "floating" to2.6.0
in CI it wasn't immediately obvious thatjbuilder-schema
was getting updated.Ideally we want to see these kinds of failures when Dependabot generates a PR to update our dependencies. In which case it would be much more obvious that a new verison of a gem is being used.