Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Prevent dependencies from floating when linking core repo #1129

Merged
merged 1 commit into from
Nov 1, 2023
Merged

[CI] Prevent dependencies from floating when linking core repo #1129

merged 1 commit into from
Nov 1, 2023

Commits on Nov 1, 2023

  1. Prevent dependencies from floating when linking core repo 

    When we do `bundle lock --update ...` that allows various dependencies
to float up to a new version if one has been released. This prevents
that from happening.

For instance in `bullet_train-api` we specify a dependency on
`jbuilder-schema` of `>= 2.4.0`. In `Gemfile.lock` of the starter repo
we had it set to `2.5.0`. But when `2.6.0` was released we started to
see failured in CI due to a bug. Since the version was just "floating"
to `2.6.0` in CI it wasn't immediately obvious that `jbuilder-schema`
was getting updated.

Ideally we want to see these kinds of failures when Dependabot generates
a PR to update our dependencies. In which case it would be much more
obvious that a new verison of a gem is being used.
    @jagthedrummer
    jagthedrummer committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    fc77f32 View commit details
    Browse the repository at this point in the history