Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable password field tests, move Super Scaffolding file tests #728

Merged
merged 11 commits into from
Aug 3, 2023
Merged

Enable password field tests, move Super Scaffolding file tests #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a265a03
Move the TestFile Super Scaffolding test
gazayas Apr 15, 2023
b16c3a8
Uncomment Super Scaffolding tests for password field
gazayas Apr 15, 2023
f4cd6b1
Change order of super scaffolding system tests
gazayas Apr 15, 2023
c851d5b
Merge branch 'main' into file-system-test
gazayas May 1, 2023
45c2dc4
Specifiy single option selection with same text as another element
gazayas May 1, 2023
b84c8c7
Fixing Standard Ruby
gazayas May 1, 2023
2711872
Add TODO for partial system tests
gazayas May 1, 2023
88de821
Merge branch 'main' into file-system-test
gazayas Aug 3, 2023
b0e298b
Remove conflicts
gazayas Aug 3, 2023
35229b0
Remove duplicated test
gazayas Aug 3, 2023
928dfdd
Remove unneeded constant
gazayas Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions test/bin/setup-super-scaffolding-system-test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ fi
if [ -z "${CIRCLE_NODE_INDEX}" ] || [ "${CIRCLE_NODE_INDEX}" == "6" ]; then
bundle exec spring rails g model TestFile team:references name:string foo:attachment
bin/super-scaffold crud TestFile Team name:text_field foo:file_field --sidebar="ti.ti-tag"
# TODO Write an actual test for this in `test/system/super_scaffolding_test.rb`.

bundle exec spring rails g model ColorPicker team:references color_picker_value:string
bin/super-scaffold crud ColorPicker Team color_picker_value:color_picker --sidebar="ti.ti-tag"
Expand All @@ -112,7 +111,6 @@ else
fi

# TODO: Generate these in parallel.
# TODO: Super Scaffold password_field partials correctly.
bundle exec spring rails g model PartialTest team:references \
text_field_test:string \
boolean_test:boolean \
Expand Down
3 changes: 2 additions & 1 deletion test/system/super_scaffolding_partial_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,8 @@ def setup
# File partial
attach_file("test/support/foo.txt", make_visible: true)
# Single Option partial
choose("One")
# TODO: Not sure why we have to specify this, but not the other button with "one".
page.all("input").find { |node| node.value == "one" }.click
# Multiple Option partial
check("One")
check("Three")
Expand Down