Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable password field tests, move Super Scaffolding file tests #728

Merged
merged 11 commits into from
Aug 3, 2023

Conversation

gazayas
Copy link
Contributor

@gazayas gazayas commented Apr 15, 2023

Addresses a couple of TODOs in the Super Scaffolding test setup script.

As far as TestFile goes, we already had a test for it in the partial test, but we can go with this PR if it belongs in super_scaffolding_test.rb instead.

@andrewculver
Copy link
Contributor

andrewculver commented Apr 29, 2023

@gazayas

@gazayas
Copy link
Contributor Author

gazayas commented May 1, 2023

Meme saved! 👆

Hadn't checked my fork in a while, 22 commits behind will do it 😅️
22 commits behind

@jagthedrummer
Copy link
Contributor

@gazayas Looks like another conflict has cropped up. If you can resolve it I'll merge this ASAP to avoid any more conflicts.

@gazayas
Copy link
Contributor Author

gazayas commented Aug 3, 2023

It looks like some of these tests were covered in #86 and #660, so there's not much left here after merging. We do get rid of the TODOs though, and add we also add one TODO related to finding a "one" option with Capybara. This one should be good to go!

@jagthedrummer jagthedrummer merged commit b96213e into bullet-train-co:main Aug 3, 2023
@gazayas gazayas deleted the file-system-test branch August 4, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants