-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use build
in ExampleBot instead of create
+ rollback
#965
Conversation
build
in ExampleBot instead of create
+ rollback
01b4ca7
to
6a2e11b
Compare
@jagthedrummer Well, I did some research, ran this on a real project, and to be honest I didn't find any noticeable differences besides empty timestamps which I fixed in last commit. Sometimes I fell into Not sure if ids should be hardcoded or sequenced like names so when there are list examples the ids would be different? So basically I'm not sure what else can go wrong. @andrewculver do you remember why we did |
@newstler, that sounds like good news! I don't have a strong opinion on generating ids/timestamps/etc vs hard coding them. If you prefer hard coding then lets do that. That's probably more stable since there's less that can unexpectedly change. I'll get these PRs rebased and cleaned up. |
6a2e11b
to
533699c
Compare
0fc7ca7
to
82fd15b
Compare
@newstler I just rebased the branches in both repos and gave everything one last review. Tests are all passing (other than when we test |
Let's try it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also have nothing against it, let's try!
82fd15b
to
03ce56e
Compare
Joint PR: bullet-train-co/bullet_train-core#524
This PR adds some dummy ids to some of the
*_example
factories. (But not any "live" factories that are used outside ofExampleBot
.)Doing this so that the values can be pre-populated for
ExampleBot
without us needing to actually create live records, clone them, rollback, then reset primary keys. Doing all of that work is slow so it's best to avoid doing it. (And having to reset primary keys for something that we expect to be a normal thing kind of gives me the willies.)