-
Notifications
You must be signed in to change notification settings - Fork 15
Configure Airflow Slack URL using Terraform #4440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Terraform plan in iac/cal-itp-data-infra-staging/composer/us Plan: 0 to add, 1 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# google_composer_environment.calitp-staging-composer will be updated in-place
!~ resource "google_composer_environment" "calitp-staging-composer" {
id = "projects/cal-itp-data-infra-staging/locations/us-west2/environments/calitp-staging-composer"
name = "calitp-staging-composer"
# (5 unchanged attributes hidden)
!~ config {
# (8 unchanged attributes hidden)
!~ software_config {
!~ env_variables = {
+ "CALITP_SLACK_URL_KEY" = (sensitive value)
# (56 unchanged elements hidden)
}
# (6 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# (8 unchanged blocks hidden)
}
# (1 unchanged block hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.📝 Plan generated in Terraform Plan #603 |
|
Terraform plan in iac/cal-itp-data-infra/composer/us Plan: 0 to add, 1 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# google_composer_environment.calitp-composer will be updated in-place
!~ resource "google_composer_environment" "calitp-composer" {
id = "projects/cal-itp-data-infra/locations/us-west2/environments/calitp-composer"
name = "calitp-composer"
# (5 unchanged attributes hidden)
!~ config {
# (8 unchanged attributes hidden)
!~ software_config {
!~ env_variables = {
+ "CALITP_SLACK_URL_KEY" = (sensitive value)
# (56 unchanged elements hidden)
}
# (6 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# (8 unchanged blocks hidden)
}
# (1 unchanged block hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.📝 Plan generated in Terraform Plan #603 |
|
Woops accidentally approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terraform fail.
|
I have another PR #4444 to give permission for Terraform to fix the error. :) |
eaa0e67 to
114f1dd
Compare
|
@vevetron Terraform permission Fixed! |
Description
This PR configures Airflow Slack URL using Terraform, so the variable is not removed anymore.
Resolves [#4363]
Type of change
How has this been tested?
Tested running "terraform plan" and "terraform apply" on staging.
Post-merge follow-ups