Skip to content

Conversation

@erikamov
Copy link
Contributor

Description

This PR adds 'secretmanager.versions.access' permission to github-actions-terraform service account in order to set up Composer variables for PR #4440.

[#4363]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Tested running "terraform plan" locally.

Post-merge follow-ups

  • No action required
  • Actions required (specified below)

Rebase PR #4440 and see if Terraform account is able to build the plan.

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

Terraform plan in iac/cal-itp-data-infra-staging/iam/us

Plan: 1 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create

Terraform will perform the following actions:

  # google_project_iam_member.github-actions-terraform["roles/secretmanager.secretAccessor"] will be created
+   resource "google_project_iam_member" "github-actions-terraform" {
+       etag    = (known after apply)
+       id      = (known after apply)
+       member  = "serviceAccount:github-actions-terraform@cal-itp-data-infra-staging.iam.gserviceaccount.com"
+       project = "cal-itp-data-infra-staging"
+       role    = "roles/secretmanager.secretAccessor"
    }

Plan: 1 to add, 0 to change, 0 to destroy.

📝 Plan generated in Terraform Plan #602

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

Terraform plan in iac/cal-itp-data-infra/iam/us

Plan: 1 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create

Terraform will perform the following actions:

  # google_project_iam_member.github-actions-terraform["roles/secretmanager.secretAccessor"] will be created
+   resource "google_project_iam_member" "github-actions-terraform" {
+       etag    = (known after apply)
+       id      = (known after apply)
+       member  = "serviceAccount:github-actions-terraform@cal-itp-data-infra.iam.gserviceaccount.com"
+       project = "cal-itp-data-infra"
+       role    = "roles/secretmanager.secretAccessor"
    }

Plan: 1 to add, 0 to change, 0 to destroy.

📝 Plan generated in Terraform Plan #602

@erikamov erikamov force-pushed the mov/4363-secret-access branch from dbf9b33 to b141985 Compare November 3, 2025 17:27
@erikamov erikamov merged commit f0f4d20 into main Nov 3, 2025
4 checks passed
@erikamov erikamov deleted the mov/4363-secret-access branch November 3, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants