Fix subscription test #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bclozel
commented
Aug 3, 2022
bclozel
commented
- Clean build file
- Remove EnableWebFlux annotation
- Clean up application properties
- Rework GraphQL controllers
- Move test query document
- Add toString
- Rewrite GraphQL subscription test
Removed websocket dependency, as this one is designed for Servlet applications. The websocket support is shipped with webflux already. Removed the kickstart dependency as there is no use for this here.
Adding this annotation disables completely the Spring Boot auto-configuration for WebFlux. See https://docs.spring.io/spring-boot/docs/current/reference/html/web.html#web.reactive.webflux.auto-configuration
Removing configuration properties already aligned with default values. Also enabling GraphiQL UI for testing locally. See http://localhost:8080/graphiql
Prior to this commit, the `getFluxOfObjects` query was not mapped nor used. This commit adds a new Greeting controller for testing a vanilla query. The subscription schema entry has been improved to take an argument setting the number of elements that should be streamed.
As of spring-projects/spring-graphql#338, the location for test documents has changed.
Prior to this commit, the test would require to manually start the application and test subscriptions with hand-crafted queries using only an HTTP client. This commit rewrites the test as a `@GraphQlTest`, which does not require a live server and uses instead a `GraphQlTester` for useful assertions. This behavior can be checked against the live server still using the graphiql UI at http://localhost:8080/graphiql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.