Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update top level config #496

Closed

Conversation

brynpickering
Copy link
Member

@brynpickering brynpickering commented Oct 24, 2023

Fixes issue #452

Possible TODO: allow init kwargs to be passed to the built-in example models on their initialisation (e.g., calliope.examples.national_scale(override_dict={"config.init.subset_time": ...}) -> calliope.examples.national_scale(subset_time=...))

TODO: add top-level parameter tests.

Summary of changes in this pull request:

  • run and model config split into init/build/solve config keys with a flat dict layout in each.
  • parameters moved out of config into a top-level parameters key with a syntax discussed in Separate top-level config and parameters  #452 and in a number of discussions.

Reviewer checklist:

  • Test(s) added to cover contribution
  • Documentation updated
  • Changelog updated
  • Coverage maintained or improved

@brynpickering
Copy link
Member Author

Closing in favour of #497

@brynpickering brynpickering deleted the update-top-level-config branch January 7, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant