-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update top level config params #497
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old backend run stuff fails now - time to remove it all!
Codecov Report
@@ Coverage Diff @@
## main #497 +/- ##
==========================================
+ Coverage 92.20% 92.36% +0.15%
==========================================
Files 32 32
Lines 4016 4045 +29
Branches 957 956 -1
==========================================
+ Hits 3703 3736 +33
+ Misses 198 196 -2
+ Partials 115 113 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #496 with new parameter names and no
equals
orscale
.Fixes issue #452
EDIT: is automatically the case
Possible TODO: allow init kwargs to be passed to the built-in example models on their initialisation (e.g.,calliope.examples.national_scale(override_dict={"config.init.subset_time": ...})
->calliope.examples.national_scale(subset_time=...)
)TODO: add top-level parameter tests.
Summary of changes in this pull request:
Reviewer checklist: