-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve measureRenders
precision
#534
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ac2fb9c The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Performance Comparison ReportSignificant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
Render Count ChangesThere are no entries Render Issues
Added ScenariosThere are no entries Removed ScenariosThere are no entries |
mdjastrzebski
force-pushed
the
feat/perf-now-timer
branch
from
October 22, 2024 12:24
919b01f
to
5f5aa15
Compare
mdjastrzebski
changed the title
feat: improve perf measurement precision (POC)
feat: improve Oct 22, 2024
measureRenders
precision
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves
measureRenders
precision from whole miliseconds to microseconds by providing a betterperformance.now
polyfil. React Native Jest preset providesDate.now()
as aperformance.now()
polyfil, but that one has milisecond precision.This issues does not occur when testing React DOM.
Resolves #516
Test plan