Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cider 2] More tests #2158

Merged
merged 13 commits into from
Jun 18, 2024
Merged

[Cider 2] More tests #2158

merged 13 commits into from
Jun 18, 2024

Conversation

EclecticGriffin
Copy link
Collaborator

Part of #1913.

This PR adds a bunch of tests and a variety of things needed to get some of them running. This includes almost the full benchmark suite used by cider 1 (I've omitted LeNet for the time being) and consequently this is a large diff for which I apologize.

For my sanity, I configured the default data-dump generated by cider to only output @external memories but this can be overridden with a new flag --all-memories which preserves the old behavior.

This also adds:

  • repeat
  • std_div_pipe
  • std_sqrt

And corrects a number of small miscellaneous bugs

@EclecticGriffin EclecticGriffin changed the title Cider2/more tests [Cider 2] More tests Jun 18, 2024
@EclecticGriffin EclecticGriffin mentioned this pull request Jun 18, 2024
22 tasks
@EclecticGriffin
Copy link
Collaborator Author

Going to let this close #2044 now, since we're running most of the test suite now.

@EclecticGriffin EclecticGriffin linked an issue Jun 18, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

@ekiwi ekiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Assuming you know that the .expect files are correct, I think we should get this. :shipit:

@EclecticGriffin EclecticGriffin merged commit 70d278b into main Jun 18, 2024
18 checks passed
@EclecticGriffin EclecticGriffin deleted the cider2/more-tests branch June 18, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cider 2] Connect to fud2 and the existing test suites
2 participants