Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cider 2.0 Tracker Issue #1913

Closed
22 tasks done
EclecticGriffin opened this issue Feb 12, 2024 · 4 comments
Closed
22 tasks done

Cider 2.0 Tracker Issue #1913

EclecticGriffin opened this issue Feb 12, 2024 · 4 comments
Assignees
Labels
C: Interpreter / Cider Calyx Interpreter & Debugger Type: Tracker Track various tasks
Milestone

Comments

@EclecticGriffin
Copy link
Collaborator

EclecticGriffin commented Feb 12, 2024

We're finally at point where we can start running programs through Cider 2 and thus it now makes sense to have a tracker for the ongoing efforts to reach parity with Cider 1.

Known issues:

@EclecticGriffin EclecticGriffin added Type: Tracker Track various tasks C: Interpreter / Cider Calyx Interpreter & Debugger labels Feb 12, 2024
@EclecticGriffin EclecticGriffin added this to the Cider 2.0 milestone Feb 12, 2024
@EclecticGriffin EclecticGriffin self-assigned this Feb 12, 2024
@rachitnigam
Copy link
Contributor

For some of these issues, like with not being supported, we should resolve the long-running with discussion and decide if we want to get rid of it completely or not.

@EclecticGriffin
Copy link
Collaborator Author

@rachitnigam Agreed, this is mostly just me getting down the current state of things. Also with is annoying to implement so I've thus far avoided it oops

@sampsyo
Copy link
Contributor

sampsyo commented Feb 27, 2024

Wahoo; thank you for summarizing! Just capturing the synchronous discussion a little bit, on this point:

Does not generate an output JSON compatible with our testing infrastructure

I had suggested, in the spirit of trying to do the simplest possible thing here, that it might not be too hard to load/dump "raw bits," i.e., the exact bit-level contents of the memories. This is more or less what the RTL simulators already do (they are using hex-encoded text, but same difference). We could then pre-/post-process these files into our JSON format externally, alleviating the need for any serde hacking on Cider's side.

This of course omits all the non-memory results that Cider 1.0 can already produce. But I believe this is fine: all we really need to check correctness is those memory dumps.

EclecticGriffin added a commit that referenced this issue Jul 23, 2024
Part of #1913. 

Small grab bag of things.
- Closes #2161 
- Adds `std_bit_slice` primitive
- Updates the data-converter to accept arbitrary precision values rather
than limiting to u64
- Data dump header is now in CBOR rather than JSON (mostly an arbitrary
choice, but at least makes it clear that the data dumps should not be
read by people)
- re-enables the polybench tests on CI
@EclecticGriffin
Copy link
Collaborator Author

Officially closing this tracker since at this point Cider 2 has replaced Cider 1 and has passed parity in terms of programs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Interpreter / Cider Calyx Interpreter & Debugger Type: Tracker Track various tasks
Projects
None yet
Development

No branches or pull requests

3 participants