[Cider 2] First Pass Multi-component and Invokes #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1913.
The main change here is having a node for all component instances present in the program counter at all times. When the
goport of the component is not high, these nodes are ignored.There is a bug with this current implementation that causes extra
stepinvocations to be required since they aren't considered until their go has been high for a cycle. This should be fixable by modifying the way assignments are gathered.The PR also includes a first attempt at invokes and ref cells, the latter of which likely still have some issues to sort out.
Added a new test suite which features variations on the same (very basic) test program.