[Cider2] Add missing Fixed Prims #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1913.
Adds the missing fixed point primitives from the std library. Dose a bit of extra work to make the printing compatible with the existing expects but it still doesn't match the printing in all cases since I'm currently using floats to print the values while the original fud printouts use
Decimalwith an aggressive 64 digits of precision. If we wanted to match that, I would probably switch to usefraction::DecimalsinceBigRationaldoesn't seem to offer a way to format things as decimals beyond just jumping to anf64as I currently am.Also for reasons that escape me the current expect files want fixed point printouts to be surrounded by quotes so there's an extra flag
--legacy-quotesfor the data converter now to do this. Still need to adjust thefud2paths to allow for flags to be passed to the converter.