Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.2 #388

Merged
merged 21 commits into from
Jan 30, 2025
Merged

Release 2.2 #388

merged 21 commits into from
Jan 30, 2025

Conversation

rartych
Copy link
Collaborator

@rartych rartych commented Jan 21, 2025

What type of PR is this?

  • subproject management

What this PR does / why we need it:

This is Release PR for release 2.2 containing version v0.5.0-rc.1 of Commonalities

Which issue(s) this PR fixes:

Fixes #384

Does this PR introduce a breaking change?

  • Yes, some of the included PR in the release are having breaking changes
  • No

Special notes for reviewers:

Changelog input

 r2.2 containing version v0.5.0-rc.1 of Commonalities


Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far. Think we can also include

#374
#390

CHANGELOG.md Outdated Show resolved Hide resolved
@rartych rartych marked this pull request as ready for review January 24, 2025 09:23
@rartych rartych requested a review from PedroDiez January 24, 2025 09:23
PedroDiez
PedroDiez previously approved these changes Jan 24, 2025
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@rartych rartych requested a review from a team January 24, 2025 09:37
Co-authored-by: Pedro Díez García <[email protected]>
PedroDiez
PedroDiez previously approved these changes Jan 24, 2025
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tanjadegroot tanjadegroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi all,
please check some comments for clarifications and a few alignment point from the Release Mgmt team.
please check an handle as appropriate. after that RM can approve and /LGTM

README.md Outdated Show resolved Hide resolved
artifacts/CAMARA_common.yaml Outdated Show resolved Hide resolved
artifacts/notification-as-cloud-event.yaml Show resolved Hide resolved
artifacts/notification-as-cloud-event.yaml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tanjadegroot
Copy link
Contributor

in /documentation
/API-linting-Implementation-Guideline.md

line 40 and 42 should have relative links per the release

@tanjadegroot
Copy link
Contributor

documentation
/Linting-rules.md

  • line 35: the info-contact field is not supported in CAMARA OASs so line 35 should say "No"
  • line 159: should be updated to say "may include "wip", "x.y.z-alpha.n" or "x.y;z-rc;n" while the API is not yer publicly released."

these changes can be done later as needed. Up to the team.

@tanjadegroot
Copy link
Contributor

tanjadegroot commented Jan 27, 2025

documentation
/UE-Identification.md

this file is very 3GPP focussed. it could be more logically placed in supporting documents (and even more logically in ICM ...) Not sure if there is a reference to it somewhere.
Also UE being a Telco term, it could be renamed to 3gpp-device-identification.md (where ever you put it.

Also inside the file terminology could be aligned (API invoker -> API consumer, UE -> device, etc), depending on the objective of this document.

Decision up to the team.

@tanjadegroot
Copy link
Contributor

tanjadegroot commented Jan 27, 2025

documentation
/Userstory-template.md

line 26 - is this reference still valid (e.g. it refers to API families), or should it point to the latest version of the CAMARA presentation (in the marketing or governance repo) or should there be an update created ?

btw, this same file is also in the local supporting documents folder, so maybe the link should point there ? (and updates would be there as well).

@tanjadegroot
Copy link
Contributor

There are 2 open PRs labeled with Spring25 - should these go into the release 2.2 or later ?

@rartych
Copy link
Collaborator Author

rartych commented Jan 28, 2025

There are 2 open PRs labeled with Spring25 - should these go into the release 2.2 or later ?

Yes labeled, but not planned in the r2.2
#277 - under final review - planned to be added for final release as it adds recommendations (considerations), no guidelines impacting API definitions
#317 - still draft can be replaced by the proposal of new guidelines document addressing #306

@rartych rartych dismissed stale reviews from patrice-conil and PedroDiez via 9c45ff8 January 28, 2025 08:33
@rartych
Copy link
Collaborator Author

rartych commented Jan 28, 2025

documentation /Linting-rules.md
/documentation /API-linting-Implementation-Guideline.md

Issue #394

@rartych
Copy link
Collaborator Author

rartych commented Jan 28, 2025

documentation /Userstory-template.md

Issue #396

@rartych
Copy link
Collaborator Author

rartych commented Jan 28, 2025

documentation /UE-Identification.md

Issue #397

@rartych
Copy link
Collaborator Author

rartych commented Jan 28, 2025

Hi all, please check some comments for clarifications and a few alignment point from the Release Mgmt team. please check an handle as appropriate. after that RM can approve and /LGTM

Thank you @tanjadegroot for thorough review.
I have opened a bunch of issues to be resolved by Commonalites - mainly related to documentation files, to be resolved before public release

@rartych rartych requested a review from tanjadegroot January 28, 2025 12:20
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tanjadegroot tanjadegroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rafal for the responses and updates.
LGTM from Release Management !

Don't forget to update the meta-release page with the new release tag and associated M2 date
here https://lf-camaraproject.atlassian.net/wiki/spaces/CAM/pages/14560849/Meta-release+Spring25

Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych merged commit 5642fa8 into camaraproject:main Jan 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commonalities r2.2
4 participants