Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(netops): Fix ip addr flush command #5651

Merged
merged 2 commits into from
Sep 4, 2024
Merged

fix(netops): Fix ip addr flush command #5651

merged 2 commits into from
Sep 4, 2024

Conversation

holmanb
Copy link
Member

@holmanb holmanb commented Aug 31, 2024 •
edited
Loading 

fix(netops): Fix ip addr flush command

Fixes GH-5648

Fixes #5648

aciba90
aciba90 approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@aciba90 aciba90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

cloudinit/net/netops/iproute2.py Show resolved Hide resolved
a-dubs
a-dubs approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@a-dubs a-dubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding all of those unit tests!

aciba90
aciba90 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@aciba90 aciba90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for adding unit-tests, @holmanb.

Feel free to merge, I am not doing it because I am not sure if you prefer squashing or not.

@holmanb
Copy link
Member Author

holmanb commented Sep 4, 2024

Updated the commit messages, thanks for the review @aciba90!

@holmanb holmanb merged commit 30addd2 into canonical:main Sep 4, 2024
19 of 21 checks passed
holmanb added a commit that referenced this pull request Sep 4, 2024
@holmanb
fix(netops): fix ip addr flush command (#5651)
3e74d5e 
Drop unnecessary environment variable.

Fixes GH-5648
blackboxsw pushed a commit to blackboxsw/cloud-init that referenced this pull request Sep 4, 2024
@holmanb @blackboxsw
fix(netops): fix ip addr flush command (canonical#5651)
3454cab 
Drop unnecessary environment variable.

Fixes canonicalGH-5648
blackboxsw pushed a commit to blackboxsw/cloud-init that referenced this pull request Sep 4, 2024
@holmanb @blackboxsw
fix(netops): fix ip addr flush command (canonical#5651)
6963dcc 
Drop unnecessary environment variable.

Fixes canonicalGH-5648
blackboxsw pushed a commit to blackboxsw/cloud-init that referenced this pull request Sep 4, 2024
@holmanb @blackboxsw
test: add test coverage for iproute2 commands (canonical#5651)
92e380e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-dubs a-dubs a-dubs approved these changes

@aciba90 aciba90 aciba90 approved these changes

Assignees

@aciba90 aciba90

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in distro.net_ops.flush_addr
3 participants
@holmanb @aciba90 @a-dubs