Fix dailies #5839
Merged
Fix dailies #5839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealFalcon
approved these changes
Oct 22, 2024
'pytest -n auto' fails with random data in parametrization, so work around it.
Since After=sysinit.target is a default dependency, a cycle is introduced when Before=sysinit.target and not DefaultDependencies=no. Fixes canonicalGH-5755
A Before= on a single service doesn't need to exist in both cloud-init-main.service and cloud-init-local.service, because cloud-init-local.service and cloud-init-main.service are themselves ordered. Only one requires it. The same applies for After=.
- RHEL family distros use ds-identify, and therefore the run directory is already made and ds-identify will have created the enabled file. - network.service doesn't appear to ever have been used, and was probably intended to be network.target.
This service is also Before=network-pre.target. NetworkManager.service is ordered After=network-pre.target Therefore, this setting is redundant.
This is required by all distros which use DefaultDependencies=no. It implicitly added by all distros which do not use DefaultDependencies=no. Therefore, it does no harm to apply it in all cases.
- There is no harm in ordering after a service which doesn't exist. - Cloud-init's final stage should consistently be ordered with respect to multi-user.target on all distros.
…ical#5835) The problem was introduced by commit 879945f
…ical#5790) This replaces the use of `/etc/rc.local` in the OpenBSD build script by the sysv init scripts provided with cloud-init. Fixes canonicalGH-4036 LP: #1992853
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
Merge type