Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dailies #5839

Merged
merged 12 commits into from
Oct 23, 2024
Merged

Fix dailies #5839

merged 12 commits into from
Oct 23, 2024

Commits on Oct 22, 2024

  1. test: unbreak pytest-xdist (canonical#5829) 

    'pytest -n auto' fails with random data in parametrization, so
work around it.
    @TheRealFalcon @holmanb
    TheRealFalcon authored and holmanb committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    56582c1 View commit details
    Browse the repository at this point in the history

  2. fix: fix ordering cycle for distros with default deps (canonical#5819) 

    Since After=sysinit.target is a default dependency, a cycle is
introduced when Before=sysinit.target and not DefaultDependencies=no.

Fixes canonicalGH-5755
    @holmanb
    holmanb committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    ec7dc6d View commit details
    Browse the repository at this point in the history

  3. chore: eliminate redundant ordering dependencies (canonical#5819) 

    A Before= on a single service doesn't need to exist in both
cloud-init-main.service and cloud-init-local.service, because
cloud-init-local.service and cloud-init-main.service are themselves
ordered. Only one requires it. The same applies for After=.
    @holmanb
    holmanb committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    addf122 View commit details
    Browse the repository at this point in the history

  4. chore: remove unnecessary systemd settings (canonical#5830) 

    - RHEL family distros use ds-identify, and therefore the run directory is
  already made and ds-identify will have created the enabled file.
- network.service doesn't appear to ever have been used, and was probably
  intended to be network.target.
    @holmanb
    holmanb committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    e72bab9 View commit details
    Browse the repository at this point in the history

  5. chore: remove redundant Before=NetworkManager.service (canonical#5830) 

    This service is also Before=network-pre.target.
NetworkManager.service is ordered After=network-pre.target
Therefore, this setting is redundant.
    @holmanb
    holmanb committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    892e196 View commit details
    Browse the repository at this point in the history

  6. chore: simplify Conflicts=shutdown.target (canonical#5830) 

    This is required by all distros which use DefaultDependencies=no.
It implicitly added by all distros which do not use DefaultDependencies=no.
Therefore, it does no harm to apply it in all cases.
    @holmanb
    holmanb committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    a300fee View commit details
    Browse the repository at this point in the history

  7. chore: simplify and standardize cloud-final.service (canonical#5830) 

    - There is no harm in ordering after a service which doesn't exist.
- Cloud-init's final stage should consistently be ordered with respect to
  multi-user.target on all distros.
    @holmanb
    holmanb committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    39260b0 View commit details
    Browse the repository at this point in the history

  8. chore: don't render non-templated unit files (canonical#5830)

    @holmanb
    holmanb committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    076d63b View commit details
    Browse the repository at this point in the history

  9. test: Fix duplicate judgment conditions in password generation (canon… 

    …ical#5835)

The problem was introduced by commit 879945f
    @xiaoge1001 @holmanb
    xiaoge1001 authored and holmanb committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    9c76610 View commit details
    Browse the repository at this point in the history

  10. fix(openbsd): Enable sysv init scripts in OpenBSD build script (canon… 

    …ical#5790)

This replaces the use of `/etc/rc.local` in the OpenBSD build script
by the sysv init scripts provided with cloud-init.

Fixes canonicalGH-4036
LP: #1992853
    @hcartiaux @holmanb
    hcartiaux authored and holmanb committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    a25026e View commit details
    Browse the repository at this point in the history

  11. fix: refresh patches

    @holmanb
    holmanb committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    04fc0d8 View commit details
    Browse the repository at this point in the history

  12. update changelog (new upstream snapshot)

    @holmanb
    holmanb committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    310a0e4 View commit details
    Browse the repository at this point in the history