-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the filebrowser rock and tests #2
Conversation
adds filebrowser/rockcraft.yaml, which implements a rock for https://github.com/filebrowser/filebrowser.
Adds basic sanity tests, but does not implement any integration tests.
Hit a lot of issues while creating this rock. They're documented in the rock and included
Along the way I also got stuck with rockcraft in a few places:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @ca-scribner . This had quite a few hard spots that needed to go around. I left some comments
Co-authored-by: Orfeas Kourkakis <[email protected]>
…ilebrowser-rock into KF-5308-add-filebrowser-rock
Co-authored-by: Orfeas Kourkakis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Andrew, very good job!
# tried to use source-subdir, but override-build ignores it. Maybe source-subdir is | ||
# implemented as part of the default build step? | ||
# source-subdir: frontend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it has been raised in canonical/craft-parts#427
This PR adds:
filebrowser/rockcraft.yaml
, which implements a rock for filebrowserfilebrowser/README.md
with some notes and instructions for future maintenancefilebrowser/tox.ini
and related sanity testsCloses canonical/kubeflow-rocks#72
Testing instructions:
testing the rock itself:
(if you want to) testing in charmed kubeflow
then